fix: clean node_modules before npm ci in post-create script (#422)

* fix: remove unnecessary coder binary move step in deployment workflow

* fix: clean node_modules before npm ci in post-create script

Ensures npm ci succeeds by removing existing node_modules before
installation. This prevents fallback to npm install and ensures
reproducible, faster installations using package-lock.json.

Changes:
- Add rm -rf node_modules before root npm ci
- Add rm -rf node_modules before frontend npm ci

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix: update coder mount paths to use isolated subdirectories and /root

- Update all host paths to use isolated subdirectories per tool
  (e.g., claude/.claude, gemini/.gemini, ssh/.ssh)
- Change all container paths from /home/vscode/ to /root/
- Update environment variables (HISTFILE, GIT_CONFIG_GLOBAL) to /root/
- Add direct mount for claude.json instead of symlink
- Remove symlink creation from post-start.sh

This ensures proper isolation and consistency for Coder workspaces.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix: use .claude.json (with dot) for host path consistency

Match exact filename on both host and container paths.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Mohsin Hashmi <mhashmi@wiser.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: 3 people

.coder/template.tf

@@ -294,8 +294,8 @@ resource "docker_container" "workspace" {
     "MAVEN_OPTS=-Xmx2g -XX:+UseG1GC -XX:+UseStringDeduplication",
     "JAVA_TOOL_OPTIONS=-XX:+UseContainerSupport -XX:MaxRAMPercentage=50.0",
     "NODE_OPTIONS=--max-old-space-size=2048",
-    "HISTFILE=/home/vscode/.bash_history_dir/bash_history",
-    "GIT_CONFIG_GLOBAL=/home/vscode/.gitconfig_dir/gitconfig"
+    "HISTFILE=/root/.bash_history_dir/bash_history",
+    "GIT_CONFIG_GLOBAL=/root/.gitconfig_dir/gitconfig"
   ]
 
   # Workspace directory (persistent Git repository)
@@ -322,49 +322,49 @@ resource "docker_container" "workspace" {
 
   # User credentials (persistent across host)
   volumes {
-    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/claude"
+    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/claude/.claude"
     container_path = "/root/.claude"
   }
 
   # Claude configuration file (must be pre-created as a file on host)
   volumes {
-    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/claude/claude.json"
+    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/claude/.claude.json"
     container_path = "/root/.claude.json"
   }
 
   volumes {
-    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/gemini"
-    container_path = "/home/vscode/.gemini"
+    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/gemini/.gemini"
+    container_path = "/root/.gemini"
   }
 
   volumes {
-    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/gh"
-    container_path = "/home/vscode/.config/gh"
+    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/.config/gh"
+    container_path = "/root/.config/gh"
   }
 
   volumes {
-    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/bash-history"
-    container_path = "/home/vscode/.bash_history_dir"
+    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/bash-history/.bash_history"
+    container_path = "/root/.bash_history_dir"
   }
 
   volumes {
-    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/gitconfig"
-    container_path = "/home/vscode/.gitconfig_dir"
+    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/gitconfig/.gitconfig"
+    container_path = "/root/.gitconfig_dir"
   }
 
   volumes {
-    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/ssh"
-    container_path = "/home/vscode/.ssh"
+    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/ssh/.ssh"
+    container_path = "/root/.ssh"
   }
 
   volumes {
-    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/docker"
-    container_path = "/home/vscode/.docker"
+    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/docker/.docker"
+    container_path = "/root/.docker"
   }
 
   volumes {
-    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/kube"
-    container_path = "/home/vscode/.kube"
+    host_path      = "/home/coder/.coder-mount/${data.coder_workspace_owner.me.name}/kube/.kube"
+    container_path = "/root/.kube"
   }
 
   # Docker socket for Docker-in-Docker

.devcontainer/post-create.sh

@@ -81,13 +81,17 @@ ensure_dir "$TARGET_HOME/.vscode-server/extensions"
 echo "📦 Installing root npm dependencies..."
 # Try npm ci first (faster, uses lock file exactly)
 # Fall back to npm install if lock file is out of sync
+# Clean node_modules first to ensure npm ci succeeds
+rm -rf node_modules
 if ! npm ci --prefer-offline 2>/dev/null; then
     echo "  ⚠️  npm ci failed, falling back to npm install..."
     npm install
 fi
 
 echo "📦 Installing frontend dependencies..."
 cd apps/frontend
+# Clean node_modules first to ensure npm ci succeeds
+rm -rf node_modules
 if ! npm ci --legacy-peer-deps --prefer-offline 2>/dev/null; then
     echo "  ⚠️  npm ci failed, falling back to npm install..."
     npm install --legacy-peer-deps

.devcontainer/post-start.sh

@@ -47,12 +47,6 @@ if [ $ELAPSED -lt $TIMEOUT ]; then
     echo "✅ Redis is ready"
 fi
 
-# Symlink Claude settings from persistent mount
-if [ -f /home/vscode/.claude/claude.json ] && [ ! -L /home/vscode/.claude.json ]; then
-    ln -sf /home/vscode/.claude/claude.json /home/vscode/.claude.json
-    echo "✅ Claude settings symlinked"
-fi
-
 # Update CLI tools to latest versions (runs in background to not block startup)
 echo "🔧 Updating CLI tools in background..."
 if [ -f /usr/local/bin/install-cli-tools ]; then