fix(devcontainer): bake tools into image and fix workspace path (#326)

- remove features from devcontainer.json (now in Dockerfile)
- add Docker CLI and GitHub CLI to Dockerfile
- remove hardcoded workspace mount from docker-compose.yml
- let DevPod handle workspace mounting automatically
- simplify post-create.sh

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Mohsin Hashmi <mhashmi@wiser.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: 3 people

.devcontainer/Dockerfile

@@ -7,7 +7,36 @@ FROM mcr.microsoft.com/devcontainers/java:21-bookworm
 ARG NODE_VERSION="20"
 RUN su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"
 
-# Install additional system dependencies
+# ============================================
+# INSTALL TOOLS (baked in for faster startup)
+# ============================================
+
+# Install Docker CLI and Docker Compose
+RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
+    && apt-get -y install --no-install-recommends \
+        apt-transport-https \
+        ca-certificates \
+        curl \
+        gnupg \
+        lsb-release \
+    && curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor -o /usr/share/keyrings/docker-archive-keyring.gpg \
+    && echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/debian $(lsb_release -cs) stable" > /etc/apt/sources.list.d/docker.list \
+    && apt-get update \
+    && apt-get -y install --no-install-recommends docker-ce-cli docker-compose-plugin \
+    && apt-get clean -y && rm -rf /var/lib/apt/lists/*
+
+# Install GitHub CLI
+RUN curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | dd of=/usr/share/keyrings/githubcli-archive-keyring.gpg \
+    && chmod go+r /usr/share/keyrings/githubcli-archive-keyring.gpg \
+    && echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" > /etc/apt/sources.list.d/github-cli.list \
+    && apt-get update \
+    && apt-get -y install --no-install-recommends gh \
+    && apt-get clean -y && rm -rf /var/lib/apt/lists/*
+
+# ============================================
+# INSTALL SYSTEM DEPENDENCIES
+# ============================================
+
 RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
     && apt-get -y install --no-install-recommends \
         postgresql-client \
@@ -40,50 +69,8 @@ ENV PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH=/usr/bin/chromium
 # Install global npm packages
 RUN su vscode -c "source /usr/local/share/nvm/nvm.sh && npm install -g npm@latest" 2>&1
 
-# ============================================
-# PRE-CACHE DEPENDENCIES FOR FASTER STARTUP
-# ============================================
-
-# Create cache directories
-RUN mkdir -p /home/vscode/.npm-cache /home/vscode/.m2-cache \
-    && chown -R vscode:vscode /home/vscode/.npm-cache /home/vscode/.m2-cache
-
-# --- NPM Dependencies ---
-# Copy package files for dependency caching
-COPY --chown=vscode:vscode package*.json /tmp/deps/
-COPY --chown=vscode:vscode apps/frontend/package*.json /tmp/deps/apps/frontend/
-
-# Install root npm dependencies
-RUN su vscode -c "source /usr/local/share/nvm/nvm.sh && cd /tmp/deps && npm install" 2>&1
-
-# Install frontend npm dependencies
-RUN su vscode -c "source /usr/local/share/nvm/nvm.sh && cd /tmp/deps/apps/frontend && npm install --legacy-peer-deps" 2>&1
-
-# --- Maven Dependencies ---
-# Copy pom.xml for Maven dependency caching
-COPY --chown=vscode:vscode apps/backend/pom.xml /tmp/deps/apps/backend/
-COPY --chown=vscode:vscode apps/backend/.mvn /tmp/deps/apps/backend/.mvn/
-COPY --chown=vscode:vscode apps/backend/mvnw /tmp/deps/apps/backend/
-
-# Download Maven dependencies
-RUN cd /tmp/deps/apps/backend \
-    && chmod +x mvnw \
-    && ./mvnw dependency:go-offline -B -q || true
-
-# Move cached dependencies to persistent locations
-RUN cp -r /tmp/deps/node_modules /home/vscode/.npm-cache/root-node_modules 2>/dev/null || true \
-    && cp -r /tmp/deps/apps/frontend/node_modules /home/vscode/.npm-cache/frontend-node_modules 2>/dev/null || true \
-    && chown -R vscode:vscode /home/vscode/.npm-cache /home/vscode/.m2
-
-# Cleanup temp files
-RUN rm -rf /tmp/deps
-
-# ============================================
-# END DEPENDENCY CACHING
-# ============================================
-
 # Set working directory
-WORKDIR /workspaces/SimpleAccounts-UAE
+WORKDIR /workspaces
 
 # Default command
 CMD ["sleep", "infinity"]

.devcontainer/devcontainer.json

@@ -4,18 +4,8 @@
   "service": "devcontainer",
   "workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
 
-  // Features to add to the dev container
-  "features": {
-    "ghcr.io/devcontainers/features/docker-in-docker:2": {
-      "moby": true,
-      "installDockerBuildx": true
-    },
-    "ghcr.io/devcontainers/features/git:1": {
-      "ppa": true,
-      "version": "latest"
-    },
-    "ghcr.io/devcontainers/features/github-cli:1": {}
-  },
+  // Docker CLI, GitHub CLI, and Git are pre-installed in the image
+  // No features needed - everything is baked into the Dockerfile for faster startup
 
   // Configure tool-specific properties
   "customizations": {

.devcontainer/docker-compose.yml

@@ -1,5 +1,3 @@
-version: '3.8'
-
 services:
   devcontainer:
     image: ghcr.io/simpleaccounts/simpleaccounts-uae-devcontainer:latest
@@ -8,7 +6,6 @@ services:
     #   context: ..
     #   dockerfile: .devcontainer/Dockerfile
     volumes:
-      - ..:/workspaces/SimpleAccounts-UAE:cached
       - devcontainer-vscode-extensions:/home/vscode/.vscode-server/extensions
       - devcontainer-maven-cache:/home/vscode/.m2
       - devcontainer-npm-cache:/home/vscode/.npm

.devcontainer/post-create.sh

@@ -5,40 +5,24 @@ set -e
 
 echo "🚀 Setting up SimpleAccounts-UAE development environment..."
 
-# --- Use cached npm dependencies if available ---
-if [ -d "/home/vscode/.npm-cache/root-node_modules" ]; then
-    echo "📦 Restoring cached root npm dependencies..."
-    cp -r /home/vscode/.npm-cache/root-node_modules ./node_modules
-    # Quick install to sync any new packages
-    npm install --prefer-offline 2>/dev/null || npm install
-else
-    echo "📦 Installing root npm dependencies..."
-    npm install
-fi
+# Install root dependencies
+echo "📦 Installing root npm dependencies..."
+npm install
 
-if [ -d "/home/vscode/.npm-cache/frontend-node_modules" ]; then
-    echo "📦 Restoring cached frontend npm dependencies..."
-    cp -r /home/vscode/.npm-cache/frontend-node_modules ./apps/frontend/node_modules
-    # Quick install to sync any new packages
-    cd apps/frontend
-    npm install --legacy-peer-deps --prefer-offline 2>/dev/null || npm install --legacy-peer-deps
-    cd ../..
-else
-    echo "📦 Installing frontend dependencies..."
-    cd apps/frontend
-    npm install --legacy-peer-deps
-    cd ../..
-fi
+# Install frontend dependencies
+echo "📦 Installing frontend dependencies..."
+cd apps/frontend
+npm install --legacy-peer-deps
+cd ../..
 
 # Install Playwright browsers (using system Chromium)
 echo "🎭 Setting up Playwright..."
 cd apps/frontend
 npx playwright install-deps 2>/dev/null || true
 cd ../..
 
-# Maven dependencies are cached in ~/.m2 which is a named volume
-# Just ensure any new dependencies are downloaded
-echo "☕ Syncing Maven dependencies..."
+# Download Maven dependencies
+echo "☕ Downloading Maven dependencies..."
 cd apps/backend
 if [ -f "./mvnw" ]; then
     chmod +x ./mvnw
@@ -77,6 +61,5 @@ fi
 echo "✅ Development environment setup complete!"
 echo ""
 echo "Quick start commands:"
-echo "  Frontend: npm run frontend"
-echo "  Backend:  npm run backend:run"
-echo "  Tests:    npm test"
+echo "  Frontend: cd apps/frontend && npm run dev"
+echo "  Backend:  cd apps/backend && ./mvnw spring-boot:run"