Further improves getDefinedFunctionsInFile()

[live627]

Support functions with union types and classes that extend fully qualified types

Can now parse nearly the entire SMF codebase as seen in my very long result set https://github.com/live627/benchmark-tests/blob/main/smf/fns.txt

My comparison script https://github.com/live627/benchmark-tests/blob/main/smf/fns.php

[Sesquipedalian]

Suggested change

	// Remove multiline comments so regex does not
	// match fake functions/classes inside them.
	$source = preg_replace('~//[^\h]+|/\*.*?\*/~s', '', $source);
	// Remove multiline comments so regex does not
	// match fake functions/classes inside them.
	$source = Config::stripPhpComments($source);

This would produce more thorough and reliable results.

Can I get you to submit a follow-up PR making this change, @live627?

[live627]

I hadn't noticed that function before now. I'm testing it now. It's quite a bit slower: the one with the token takes 0.43s, while the custom algorithm takes 0.38s. The one in this branch takes 0.08s.

That custom implementation also missed a function.

(new regex = mine, old regex = your suggested change without the tokenizer)

Files:        1599
Iterations:   1

New regex total: 79.910 ms
Old regex total: 378.003 ms

New regex avg:   79.910 ms
Old regex avg:   378.003 ms

Speedup:         4.73x (new regex faster)

New regex count: 4420
Old regex count: 4419

Differences detected:

../../smf2.1/sources\Subs-Compat.php
  New regex only:
    + package_crypt