Skip to content

[3.0] Misc fixes for SMF\User#9260

Merged
Sesquipedalian merged 8 commits into
SimpleMachines:release-3.0from
Sesquipedalian:3.0/user_fixes
Jun 10, 2026
Merged

[3.0] Misc fixes for SMF\User#9260
Sesquipedalian merged 8 commits into
SimpleMachines:release-3.0from
Sesquipedalian:3.0/user_fixes

Conversation

@Sesquipedalian

Copy link
Copy Markdown
Member
  1. Applies bans and warnings correctly in SMF\User::kickIfBanned()
    • Referred to an object property that doesn't exist rather than the property that does.
  2. Fixes bug checking spoofed names in User::isReservedName()
    • Fixes an incorrect variable name.
  3. Fixes queries in SMF\Tasks\AnonymizeEditHistory::execute()
    • Fixes incorrect argument order when passing arguments to Db::$db->query().
  4. Respects custom themes' membergroup icons in SMF\User::format()
    • Previously, custom themes' membergroup icons would be overwritten by the default theme's.
  5. Correctly updates loaded objects in SMF\User::updateMemberData()
    • Previously passed [$var, $val] to set() method, but should have passed [$var => $val].
  6. Fixes type of SMF\User::$time_offset
    • Float, not int.
  7. Preserves buddy list in User properties even if feature is disabled
    • Previously, this data was handled inconsistently and could be permanently lost if the related feature was disabled.
  8. Preserve ignored boards in User properties even if feature is disabled
    • Previously, this data was handled inconsistently and could be permanently lost if the related feature was disabled.

Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
@Sesquipedalian Sesquipedalian added this to the 3.0 Alpha 5 milestone Jun 10, 2026
@Sesquipedalian Sesquipedalian merged commit 43da625 into SimpleMachines:release-3.0 Jun 10, 2026
4 checks passed
@Sesquipedalian Sesquipedalian deleted the 3.0/user_fixes branch June 10, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant