[2.1] Upgrader - Disable timeouts#9270
Open
sbulen wants to merge 2 commits into
Open
Conversation
Signed-off-by: Shawn Bulen <bulens@pacbell.net>
…outs Signed-off-by: Shawn Bulen <bulens@pacbell.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9259 for other issues with large DB upgrades
In hindsight, why have timeouts at all. Let things complete. We know they run long. Random timeouts hidden from sight are frustrating and add delays to the overall process.
When run via browser, a timeout provides no visual indication that it happened. The upgrader reports possible timeouts after 30 secs of inactivity, but most of these are bogus - many actions take longer than 30 seconds on mid-to-large sized forums. So the user gets trained to ignore them. So... The user has no idea when a real timeout occurs, since the 30-second warning is normal.
The only reliable way I know of to see if the upgrader is actually running or not today is to do a SHOW PROCESSLIST at the DB console.
This PR makes the process much easier & more friendly. And faster - no idle-time when it's not doing anything but waiting for someone to catch on & restart it... You KNOW it's running. And no time wasted rerunning upgrader steps over & over upon each restart.
I also think we see data loss/corruption when long-running steps get restarted repeatedly. At some point, it skips over remaining work.
This one is ready to go. If approved, I'll work on the 3.0 version.