Skip to content

Commit 3d38b07

Browse files
committed
reuse the shared openFile way of opening last media file
1 parent 7320798 commit 3d38b07

17 files changed

Lines changed: 17 additions & 29 deletions

File tree

app/src/main/AndroidManifest.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,5 +93,15 @@
9393
<action android:name="android.intent.action.CAMERA_BUTTON"/>
9494
</intent-filter>
9595
</receiver>
96+
97+
<provider
98+
android:name="android.support.v4.content.FileProvider"
99+
android:authorities="${applicationId}.provider"
100+
android:exported="false"
101+
android:grantUriPermissions="true">
102+
<meta-data
103+
android:name="android.support.FILE_PROVIDER_PATHS"
104+
android:resource="@xml/provider_paths"/>
105+
</provider>
96106
</application>
97107
</manifest>

app/src/main/kotlin/com/simplemobiletools/camera/activities/MainActivity.kt

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.simplemobiletools.camera.activities
22

33
import android.app.Activity
4-
import android.content.ActivityNotFoundException
54
import android.content.Intent
65
import android.content.res.Resources
76
import android.hardware.Camera
@@ -198,20 +197,8 @@ class MainActivity : SimpleActivity(), PreviewListener, PhotoProcessor.MediaSave
198197
}
199198

200199
private fun showLastMediaPreview() {
201-
if (mPreviewUri == null)
202-
return
203-
204-
try {
205-
val REVIEW_ACTION = "com.android.camera.action.REVIEW"
206-
val intent = Intent(REVIEW_ACTION, mPreviewUri)
207-
startActivity(intent)
208-
} catch (e: ActivityNotFoundException) {
209-
val intent = Intent(Intent.ACTION_VIEW, mPreviewUri)
210-
if (intent.resolveActivity(packageManager) != null) {
211-
startActivity(intent)
212-
} else {
213-
toast(R.string.no_gallery_app_available)
214-
}
200+
if (mPreviewUri != null) {
201+
openFile(mPreviewUri!!, false, BuildConfig.APPLICATION_ID)
215202
}
216203
}
217204

app/src/main/res/values-de/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<string name="camera_switch_error">Kamerawechsel fehlgeschlagen</string>
1111
<string name="no_permissions">Ohne Zugriff auf Kamera und Speicher ist hier nicht viel zu tun</string>
1212
<string name="no_audio_permissions">Wir benötigen Zugriff auf das Mikrofon um Videos aufnehmen zu können</string>
13-
<string name="no_gallery_app_available">Keine Galerie-App verfügbar</string>
1413
<string name="click_to_resume_preview">Klicke auf das Bild, um bei der Vorschau zu bleiben</string>
1514
<string name="photo_not_saved">Das Foto konnte nicht gespeichert werden</string>
1615

app/src/main/res/values-es/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<string name="camera_switch_error">Ha fallado el cambio de cámara</string>
1111
<string name="no_permissions">No hay mucho que hacer sin los permisos para acceder a la cámara y al almacenamiento</string>
1212
<string name="no_audio_permissions">Se necesita el permiso de micrófono para grabar vídeos</string>
13-
<string name="no_gallery_app_available">No hay disponible una aplicación de galería</string>
1413
<string name="click_to_resume_preview">Haga clic en la imagen para reanudar la vista previa</string>
1514
<string name="photo_not_saved">The photo could not be saved</string>
1615

app/src/main/res/values-fr/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<string name="camera_switch_error">La permutation de caméra a échouée</string>
1111
<string name="no_permissions">Peu de choses à faire sans accès à la caméra et à la mémoire</string>
1212
<string name="no_audio_permissions">Nous avons besoin de l\'autorisation sur l\'audio pour enregistrer des vidéos</string>
13-
<string name="no_gallery_app_available">Pas d\'application galerie disponible</string>
1413
<string name="click_to_resume_preview">Cliquer sur l\'image pour resume preview</string>
1514
<string name="photo_not_saved">La photo ne peut pas être sauvegardée</string>
1615

app/src/main/res/values-it/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<string name="camera_switch_error">Cambio fotocamera fallito</string>
1111
<string name="no_permissions">Non c\'è molto da fare senza l\'accesso alla fotocamera e all\'archiviazione</string>
1212
<string name="no_audio_permissions">È necessario l\'accesso al microfono per registrare i video</string>
13-
<string name="no_gallery_app_available">Nessuna app galleria disponibile</string>
1413
<string name="click_to_resume_preview">Click on the image to resume preview</string>
1514
<string name="photo_not_saved">The photo could not be saved</string>
1615

app/src/main/res/values-ja/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<string name="camera_switch_error">カメラの切り替えに失敗しました</string>
1111
<string name="no_permissions">お使いのカメラやストレージにアクセスしないと、ほとんど行うことはありません</string>
1212
<string name="no_audio_permissions">ビデオを記録するためにオーディオのアクセス許可が必要です</string>
13-
<string name="no_gallery_app_available">利用可能なギャラリーアプリがありません</string>
1413
<string name="click_to_resume_preview">Click on the image to resume preview</string>
1514
<string name="photo_not_saved">The photo could not be saved</string>
1615

app/src/main/res/values-lt/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<string name="camera_switch_error">Kameros perjungimas nepavyko</string>
1111
<string name="no_permissions">Nėra ką daryti kai kamera ir saugykla neprieinama</string>
1212
<string name="no_audio_permissions">Mums reikia audio leidimo, kad įrašyti vaizdo bylas</string>
13-
<string name="no_gallery_app_available">Nėra galerijos programėlės</string>
1413
<string name="click_to_resume_preview">Click on the image to resume preview</string>
1514
<string name="photo_not_saved">The photo could not be saved</string>
1615

app/src/main/res/values-nl/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<string name="camera_switch_error">Schakelen camera is mislukt</string>
1111
<string name="no_permissions">Kan niets doen zonder toegang tot uw camera en opslag</string>
1212
<string name="no_audio_permissions">Toestemming voor audio nodig is voor het opnemen van video\'s</string>
13-
<string name="no_gallery_app_available">Geen gallery app beschikbaar</string>
1413
<string name="click_to_resume_preview">Click on the image to resume preview</string>
1514
<string name="photo_not_saved">The photo could not be saved</string>
1615

app/src/main/res/values-pl/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<string name="camera_switch_error">Przełączenie kamery nie powiodło się</string>
1111
<string name="no_permissions">Za wiele nie zrobię, gdy nie będę mieć dostępu do kamery i pamięci.</string>
1212
<string name="no_audio_permissions">Potrzebuję ustawienia \"Mikrofon\", aby móc nagrywać filmy</string>
13-
<string name="no_gallery_app_available">Brak aplikacji galerii</string>
1413
<string name="click_to_resume_preview">Kliknij obraz, aby wznowić podgląd</string>
1514
<string name="photo_not_saved">Zdjęcie nie mogło zostać zapisane</string>
1615

0 commit comments

Comments
 (0)