fix: make all env vars required, no defaults

Author: bendersej

agent-pdf/src/config.rs

@@ -10,19 +10,16 @@ pub struct Config {
 
 impl Config {
     pub fn from_env() -> Self {
-        let s3_endpoint = env("S3_ENDPOINT");
-        let s3_bucket = env("S3_BUCKET");
-
         Self {
-            s3_region: env_or("S3_REGION", "us-east-1"),
-            s3_public_url: env_or("S3_PUBLIC_URL", &s3_endpoint),
-            s3_endpoint,
-            s3_bucket,
-            default_editor_host: env_or("DEFAULT_EDITOR_HOST", "ai.simplepdf.com"),
-            rate_limit_per_minute: env_or("RATE_LIMIT_PER_MIN", "30")
+            s3_endpoint: env("S3_ENDPOINT"),
+            s3_bucket: env("S3_BUCKET"),
+            s3_region: env("S3_REGION"),
+            s3_public_url: env("S3_PUBLIC_URL"),
+            default_editor_host: env("DEFAULT_EDITOR_HOST"),
+            rate_limit_per_minute: env("RATE_LIMIT_PER_MIN")
                 .parse()
                 .expect("RATE_LIMIT_PER_MIN must be a number"),
-            trust_proxy: env_or("TRUST_PROXY", "false") == "true",
+            trust_proxy: env("TRUST_PROXY") == "true",
         }
     }
 
@@ -37,7 +34,3 @@ impl Config {
 fn env(key: &str) -> String {
     std::env::var(key).unwrap_or_else(|_| panic!("{key} must be set"))
 }
-
-fn env_or(key: &str, default: &str) -> String {
-    std::env::var(key).unwrap_or_else(|_| default.to_string())
-}