Merge pull request #63 from SimpleSoftwareIO/analysis-q13Wv3

Apply fixes from StyleCI

Author: SimplyCorey

src/DriverManager.php

@@ -4,19 +4,19 @@
 
 use GuzzleHttp\Client;
 use Illuminate\Support\Manager;
-use SimpleSoftwareIO\SMS\Drivers\CallFireSMS;
-use SimpleSoftwareIO\SMS\Drivers\EmailSMS;
-use SimpleSoftwareIO\SMS\Drivers\EZTextingSMS;
-use SimpleSoftwareIO\SMS\Drivers\FlowrouteSMS;
-use SimpleSoftwareIO\SMS\Drivers\JustSendSMS;
-use SimpleSoftwareIO\SMS\Drivers\LabsMobileSMS;
+use SimpleSoftwareIO\SMS\Drivers\SMS77;
 use SimpleSoftwareIO\SMS\Drivers\LogSMS;
+use SimpleSoftwareIO\SMS\Drivers\EmailSMS;
 use SimpleSoftwareIO\SMS\Drivers\MozeoSMS;
 use SimpleSoftwareIO\SMS\Drivers\NexmoSMS;
 use SimpleSoftwareIO\SMS\Drivers\PlivoSMS;
-use SimpleSoftwareIO\SMS\Drivers\SMS77;
 use SimpleSoftwareIO\SMS\Drivers\TwilioSMS;
 use SimpleSoftwareIO\SMS\Drivers\ZenviaSMS;
+use SimpleSoftwareIO\SMS\Drivers\CallFireSMS;
+use SimpleSoftwareIO\SMS\Drivers\JustSendSMS;
+use SimpleSoftwareIO\SMS\Drivers\EZTextingSMS;
+use SimpleSoftwareIO\SMS\Drivers\FlowrouteSMS;
+use SimpleSoftwareIO\SMS\Drivers\LabsMobileSMS;
 
 class DriverManager extends Manager
 {

src/Drivers/AbstractSMS.php

@@ -7,7 +7,6 @@
 
 abstract class AbstractSMS
 {
-
     protected $debug;
 
     /**
@@ -72,14 +71,12 @@ protected function makeMessage($rawMessage)
     abstract protected function processReceive($rawMessage);
 
     /**
-     * Defines if debug is enabled or disabled (SMS77)
+     * Defines if debug is enabled or disabled (SMS77).
      *
      * @param $debug
      */
     public function setDebug($debug)
     {
         $this->debug = $debug;
     }
-
-
 }

src/Drivers/EmailSMS.php

@@ -116,13 +116,11 @@ protected function lookupGateway($carrier, $mms)
 
                 case 'airfiremobile':
                     throw new \InvalidArgumentException('Air Fire Mobile does not support Email Gateway MMS messages.');
-
                 case 'alaskacommunicates':
                     return 'msg.acsalaska.com';
 
                 case 'ameritech':
                     throw new \InvalidArgumentException('Ameritech does not support Email Gateway MMS messages.');
-
                 case 'assurancewireless':
                     return 'vmobl.com';
 
@@ -131,7 +129,6 @@ protected function lookupGateway($carrier, $mms)
 
                 case 'cleartalk':
                     throw new \InvalidArgumentException('Clear Talk does not support Email Gateway MMS messages.');
-
                 case 'cricket':
                     return 'mms.mycricket.com ';
 
@@ -140,7 +137,6 @@ protected function lookupGateway($carrier, $mms)
 
                 case 'nextech':
                     throw new \InvalidArgumentException('NexTech does not support Email Gateway MMS messages.');
-
                 case 'projectfi':
                     return 'msg.fi.google.com';
 

src/Drivers/LabsMobileSMS.php

@@ -3,8 +3,8 @@
 namespace SimpleSoftwareIO\SMS\Drivers;
 
 use GuzzleHttp\Client;
-use SimpleSoftwareIO\SMS\DoesNotReceive;
 use SimpleSoftwareIO\SMS\MakesRequests;
+use SimpleSoftwareIO\SMS\DoesNotReceive;
 use SimpleSoftwareIO\SMS\OutgoingMessage;
 
 class LabsMobileSMS extends AbstractSMS implements DriverInterface

src/Drivers/MozeoSMS.php

@@ -3,8 +3,8 @@
 namespace SimpleSoftwareIO\SMS\Drivers;
 
 use GuzzleHttp\Client;
-use SimpleSoftwareIO\SMS\DoesNotReceive;
 use SimpleSoftwareIO\SMS\MakesRequests;
+use SimpleSoftwareIO\SMS\DoesNotReceive;
 use SimpleSoftwareIO\SMS\OutgoingMessage;
 
 class MozeoSMS extends AbstractSMS implements DriverInterface

src/Drivers/PlivoSMS.php

@@ -148,7 +148,7 @@ protected function validateRequest()
         $signature = $_SERVER['X-Plivo-Signature'];
         $authToken = $this->authToken;
 
-        if (!$this->plivo->validate_signature($url, $data, $signature, $authToken)) {
+        if (! $this->plivo->validate_signature($url, $data, $signature, $authToken)) {
             throw new \InvalidArgumentException('This request was not able to verify it came from Plivo.');
         }
 

src/Drivers/SMS77.php

@@ -1,9 +1,10 @@
 <?php
+
 namespace SimpleSoftwareIO\SMS\Drivers;
 
 use GuzzleHttp\Client;
-use SimpleSoftwareIO\SMS\DoesNotReceive;
 use SimpleSoftwareIO\SMS\MakesRequests;
+use SimpleSoftwareIO\SMS\DoesNotReceive;
 use SimpleSoftwareIO\SMS\OutgoingMessage;
 
 class SMS77 extends AbstractSMS implements DriverInterface
@@ -67,11 +68,12 @@ public function send(OutgoingMessage $message)
         if ($this->hasError($responseBody)) {
             $this->handleError($responseBody);
         }
+
         return $response;
     }
 
     /**
-     * Checks if the transaction has an error
+     * Checks if the transaction has an error.
      *
      * @param $body
      * @return bool
@@ -81,20 +83,21 @@ protected function hasError($body)
         if ($body != '100') {
             return $body;
         }
+
         return false;
     }
 
     /**
-     * Log the error message which ocurred
+     * Log the error message which ocurred.
      *
      * @param $body
      */
     protected function handleError($body)
     {
-        $error = 'An error occurred. Status code: ' . $body . ' - ';
+        $error = 'An error occurred. Status code: '.$body.' - ';
 
         //From https://www.sms77.de/api.pdf Rückgabewerte (German doc)
-        switch($body){
+        switch ($body) {
             case '101':
                 $error .= 'Versand an mindestens einen Empfänger fehlgeschlagen';
                 break;

src/Drivers/ZenviaSMS.php

@@ -9,7 +9,7 @@
 class ZenviaSMS extends AbstractSMS implements DriverInterface
 {
     use MakesRequests;
-    
+
     /**
      * The API's URL.
      *
@@ -119,7 +119,7 @@ public function checkMessages(array $options = [])
 
         $jsonResponse = json_decode($this->postRequest()->getBody()->getContents());
 
-        if (!isset($jsonResponse->receivedResponse)) {
+        if (! isset($jsonResponse->receivedResponse)) {
             throw new \Exception('Invalid response from API. Missing mandatory object.');
         }
 
@@ -244,7 +244,7 @@ private function generateMessageBody($from, $number, $composeMessage)
             'callbackOption' => $this->callbackOption,
         ];
 
-        if (!is_null($number['carrier'])) {
+        if (! is_null($number['carrier'])) {
             $aux['id'] = $number['carrier'];
         }
 

src/MakesRequests.php

@@ -32,7 +32,7 @@ trait MakesRequests
      */
     protected function buildCall($url)
     {
-        if (!$this->callBuilt) {
+        if (! $this->callBuilt) {
             $this->apiBase .= $url;
             $this->callBuilt = true;
         }

src/SMS.php

@@ -3,11 +3,11 @@
 namespace SimpleSoftwareIO\SMS;
 
 use Closure;
-use Illuminate\Container\Container;
-use Illuminate\Queue\QueueManager;
 use Illuminate\Support\Str;
-use SimpleSoftwareIO\SMS\Drivers\DriverInterface;
 use SuperClosure\Serializer;
+use Illuminate\Queue\QueueManager;
+use Illuminate\Container\Container;
+use SimpleSoftwareIO\SMS\Drivers\DriverInterface;
 
 class SMS
 {
@@ -191,7 +191,7 @@ public function laterOn($queue, $delay, $view, $data, $callback)
      */
     protected function buildQueueCallable($callback)
     {
-        if (!$callback instanceof Closure) {
+        if (! $callback instanceof Closure) {
             return $callback;
         }