Skip to content

Commit 30af731

Browse files
committed
Revert "Add failing SSProperty to AMTL CAGRAD and MGDA"
This reverts commit ee27d3d.
1 parent ee27d3d commit 30af731

3 files changed

Lines changed: 5 additions & 21 deletions

File tree

tests/unit/aggregation/test_aligned_mtl.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,11 @@
33

44
from torchjd.aggregation import AlignedMTL
55

6-
from ._property_testers import (
7-
ExpectedStructureProperty,
8-
PermutationInvarianceProperty,
9-
StrongStationarityProperty,
10-
)
6+
from ._property_testers import ExpectedStructureProperty, PermutationInvarianceProperty
117

128

139
@mark.parametrize("aggregator", [AlignedMTL()])
14-
class TestAlignedMTL(
15-
ExpectedStructureProperty, PermutationInvarianceProperty, StrongStationarityProperty
16-
):
10+
class TestAlignedMTL(ExpectedStructureProperty, PermutationInvarianceProperty):
1711
pass
1812

1913

tests/unit/aggregation/test_cagrad.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,11 @@
88
from torchjd.aggregation import CAGrad, Mean
99

1010
from ._inputs import typical_matrices
11-
from ._property_testers import (
12-
ExpectedStructureProperty,
13-
NonConflictingProperty,
14-
StrongStationarityProperty,
15-
)
11+
from ._property_testers import ExpectedStructureProperty, NonConflictingProperty
1612

1713

1814
@mark.parametrize("aggregator", [CAGrad(c=0.5)])
19-
class TestCAGrad(ExpectedStructureProperty, StrongStationarityProperty):
15+
class TestCAGrad(ExpectedStructureProperty):
2016
pass
2117

2218

tests/unit/aggregation/test_mgda.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,11 @@
99
ExpectedStructureProperty,
1010
NonConflictingProperty,
1111
PermutationInvarianceProperty,
12-
StrongStationarityProperty,
1312
)
1413

1514

1615
@mark.parametrize("aggregator", [MGDA()])
17-
class TestMGDA(
18-
ExpectedStructureProperty,
19-
NonConflictingProperty,
20-
PermutationInvarianceProperty,
21-
StrongStationarityProperty,
22-
):
16+
class TestMGDA(ExpectedStructureProperty, NonConflictingProperty, PermutationInvarianceProperty):
2317
pass
2418

2519

0 commit comments

Comments
 (0)