Skip to content

Commit 3c35de7

Browse files
authored
docs(aggregation): Add comment in NashMTL (#319)
1 parent 4dcf732 commit 3c35de7

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/torchjd/aggregation/nash_mtl.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,9 @@ def _solve_optimization(self, gtg: np.ndarray) -> np.ndarray:
148148
try:
149149
self.prob.solve(solver=cp.ECOS, warm_start=True, max_iters=100)
150150
except Exception:
151+
# On macOS, this can happen with a cvxpy.error.SolverError: Solver 'ECOS' failed.
152+
# No idea why. The corresponding matrix is of shape [9, 11] with rank 5.
153+
# Maybe other exceptions can happen in other cases.
151154
self.alpha_param.value = self.prvs_alpha_param.value
152155

153156
if self._stop_criteria(gtg, alpha_t):

0 commit comments

Comments
 (0)