Skip to content

Commit a8ef620

Browse files
committed
Simplify optional deps logic, make full the default in the action
1 parent 8901660 commit a8ef620

3 files changed

Lines changed: 4 additions & 7 deletions

File tree

.github/actions/install-deps/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ inputs:
55
options:
66
description: 'Package options to install (space-separated, e.g., "full")'
77
required: false
8-
default: ''
8+
default: 'full'
99
groups:
1010
description: 'Dependency groups to install (space-separated, e.g., "test doc")'
1111
required: false

.github/workflows/build-deploy-docs.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ jobs:
2727

2828
- uses: ./.github/actions/install-deps
2929
with:
30-
options: full
3130
groups: doc
3231

3332
- name: Determine deployment folder

.github/workflows/tests.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
tests:
1414
# Default config: py3.14, ubuntu-latest, float32, full options.
1515
# The idea is to make each of those params vary one by one, to limit the number of tests to run.
16-
name: Run tests (py${{ matrix.python-version || '3.14' }}, ${{ matrix.os || 'ubuntu-latest' }}, ${{ matrix.dtype || 'float32' }}, options=[${{ matrix.options == 'none' && '' || (matrix.options || 'full') }}])
16+
name: Run tests (py${{ matrix.python-version || '3.14' }}, ${{ matrix.os || 'ubuntu-latest' }}, ${{ matrix.dtype || 'float32' }}${{ matrix.options != null && ', default install'}})
1717
runs-on: ${{ matrix.os || 'ubuntu-latest' }}
1818
strategy:
1919
fail-fast: false
@@ -31,7 +31,7 @@ jobs:
3131
# dtype variations
3232
- dtype: float64
3333
# Installation options variations
34-
- options: none
34+
- options: ''
3535

3636
steps:
3737
- name: Checkout repository
@@ -44,7 +44,7 @@ jobs:
4444

4545
- uses: ./.github/actions/install-deps
4646
with:
47-
options: ${{ matrix.options == 'none' && '' || (matrix.options || 'full') }}
47+
options: ${{ matrix.options }}
4848
groups: test
4949

5050
- name: Run tests
@@ -72,7 +72,6 @@ jobs:
7272

7373
- uses: ./.github/actions/install-deps
7474
with:
75-
options: full
7675
groups: doc
7776

7877
- name: Build Documentation
@@ -93,7 +92,6 @@ jobs:
9392

9493
- uses: ./.github/actions/install-deps
9594
with:
96-
options: full
9795
groups: check
9896

9997
- name: Run mypy

0 commit comments

Comments
 (0)