Improve input matrix generation by PierreQuinton · Pull Request #256 · SimplexLab/TorchJD

PierreQuinton · 2025-02-23T15:45:58Z

Refactor how test matrices are generated
Make matrix generation functions all protected
Make NonConflictingProperty use weak stationary matrices rather than strong
Remove the 1x1 matrix from the generated stationary matrices

…nd weak stationarity

codecov · 2025-02-23T15:47:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…s - 1). The reason for that is we want to make sure for weak stationary that there is no 0<w with J^Tw=0.

This is as suggested by the warning that torch.qr raises (it is deprecated).

…ak_stationary_matrix

ValerianRey · 2025-03-18T19:10:52Z

LGTM, waiting for approval of my own changes.

PierreQuinton · 2025-03-19T09:01:36Z

LGTM, except the name of the functions, I don't know why I called those like that, but we are generating unitary matrices, which are also orthogonal, but unitary is better.

PierreQuinton added 4 commits February 23, 2025 13:57

Remove tests of shape and rank of matrices

8fce23f

Reimplements matrices generation, adds a distinction between strong a…

c6b4798

…nd weak stationarity

Improve naming of matrices

d3bd73b

Add testing of weak stationary matrices for the non-conflicting property

7b4cfb7

PierreQuinton added cc: test Conventional commit type for changes to tests. package: aggregation cc: chore Conventional commit type for changes to some configuration files of the project. labels Feb 23, 2025

PierreQuinton requested a review from ValerianRey February 23, 2025 15:45

make utility functions protected

4142861

PierreQuinton removed the cc: chore Conventional commit type for changes to some configuration files of the project. label Feb 23, 2025

PierreQuinton and others added 10 commits February 24, 2025 11:02

Stationary matrices are now of rank exactly of rank=min(n_cols, n_row…

088c32f

…s - 1). The reason for that is we want to make sure for weak stationary that there is no 0<w with J^Tw=0.

Remove [1,1] matrix from set of stationary matrices.

ec6caa7

Replace torch.qr by torch.linalg.qr

9bbe4de

This is as suggested by the warning that torch.qr raises (it is deprecated).

Reorder functions

a618862

Fix docstring of _generate_orthogonal_matrix

6054aaf

Fix docstring formatting

e91a313

Fix docstrings of _generate_strong_stationary_matrix and _generate_we…

181f0bd

…ak_stationary_matrix

Fix docstring formatting

ba95e7a

Fix docstring formatting

974a45c

Fix docstring of _generate_matrix_with_orthogonal_vector

da8ef38

ValerianRey reviewed Mar 18, 2025

View reviewed changes