Merged
Conversation
- The reason is that it's easier to have scaled_matrices and matrices disjoint. We can test on matrices + scaled_matrices instead of just matrices for the same effect.
- It somehow does not pass on 1 matrix when run on GPU.
ValerianRey
added
cc: test
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
PierreQuinton
approved these changes
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to remove the PermutationInvarianceProperty from TestIMTLG, because with the new parametrization, on GPU, one permutation-invariance test fails for IMTLG. I think this could be related to the use of torch.linalg.pinv in IMTLG, because ConFIG also had the same issue of mysteriously failing some permutation-invariance tests and it also uses torch.linalg.pinv. Maybe in some cases this pseudoinverse is not unique and leads to different solutions?