Make _pref_vector_to_weighting check input itself#265
Merged
ValerianRey merged 2 commits intomainfrom Mar 24, 2025
Merged
Conversation
Contributor
ValerianRey
commented
Mar 24, 2025
ValerianRey
commented
- Move pref_vector validation into _pref_vector_to_weighting
- Add test_pref_vector_to_weighting_check
ValerianRey
added
package: aggregation
cc: refactor
ValerianRey
changed the title
_pref_vector_to_weighting check input itself
ValerianRey
force-pushed
the
change-pref-vector
branch
from
9521ef0 to
46ed3de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
PierreQuinton
approved these changes
Mar 24, 2025
Contributor
PierreQuinton
left a comment
PierreQuinton
left a comment
There was a problem hiding this comment.
Perfect, I guess we never (and will never) use _pref_vector_to_weighting without testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.