Merged
Conversation
ValerianRey
added
package: aggregation
cc: fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
PierreQuinton
approved these changes
Mar 25, 2025
ValerianRey
deleted the
remove-exception-handling-in-imtlg-and-aligned-mtl
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason why we added those exception catchings was that we used to test on matrices with an extremely large scale factor (like 1e20). Users don't usually need aggregators to work on such matrices. And in those cases, we barely made the aggregators give a result, not the result that they were supposed to give. For those reasons this change is like a fix removing something fairly arbitrary and not used in practice.