Merged
Conversation
…d to an empty list of outputs
ValerianRey
added
package: autojac
cc: fix
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
PierreQuinton
approved these changes
Mar 25, 2025
Contributor
PierreQuinton
left a comment
PierreQuinton
left a comment
There was a problem hiding this comment.
coverage will be added in later PR, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
outputsis an empty list, we are implicitly summing no gradients. The identity element w.r.t. the summation of tensors of the same shape as the inputs is tensors of zeros of the same shape as the inputs, not tensors of nan values like we had. This is an internal fix since there is currently no way to call Grad with empty outputs with the current public interface of torchjd.