Add test_stack_different_required_keys#274
Merged
ValerianRey merged 1 commit intomainfrom Mar 26, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
9fbd3d3 to
4163499
Compare
PierreQuinton
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At first, I wanted to make this test in
test_stack.py, but actually, it depends on other transforms: we can't specify required keys with theFakeGradientsTransformdefined intest_stack.py, and I think test files of autojac currently only depend on the transforms that they test, except fortest_interactions.pywhich contains tests combining multiple transforms.The alternative would have been to create another fake transform in
test_stack.py, for instance one that would require some keys but that would not produce any output (kind of the opposite of theFakeGradientsTransform). I'm not sure it's worth the effort, and I like having this test apply on a real transform like Grad, so I prefer what I did.