Fix differentiation with repeated tensors#277
Merged
ValerianRey merged 8 commits intomainfrom Mar 26, 2025
Merged
Conversation
Contributor
ValerianRey
commented
Mar 26, 2025
ValerianRey
commented
- Add tests with repeated tensors for backward
- Add tests with repeated tensors for mtl_backward
- Remove check of uniqueness of the elements provided to ordered_set
- Remove casting outputs to ordered_set in _Differentiate
- Add changelog entry
- Note that this makes Jac and Grad able to respect repetition in their outputs parameter, which fixes backward and mtl_backward behavior when dealing with repeated tensors
ValerianRey
added
package: autojac
cc: fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
PierreQuinton
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.