Isolate key checks in transforms#279

Merged

ValerianRey merged 23 commits intomainfrom

decouple_construction_check_in_transforms

Mar 28, 2025

Commits on Mar 28, 2025

Decouple construction and checking in Transforms
PierreQuinton
committed
add check_keys in test_stack.FakeGradientsTransform
PierreQuinton
committed
Fix tests checking Transforms
PierreQuinton
committed
remove test_call_checks_keys
PierreQuinton
committed
Add changelog entry
ValerianRey
committed
Extract _create_transform from backward
PierreQuinton
committed
Test _create_transform
PierreQuinton
committed
Fix mtl_backward test of create transform and check keys
PierreQuinton
committed
Remove _compute, use __call__ instead
ValerianRey
committed
Same as before for FakeTransforms
ValerianRey
committed
Rename check_keys to check_and_get_keys
ValerianRey
committed
Improve docstring of check_and_get_keys
ValerianRey
committed
Fix tests of check_and_get_keys
ValerianRey
committed
Move check and cast to set from __init__ to check_and_get_keys in Select
ValerianRey
committed
Change test_keys_check into test_check_and_get_keys in Select
ValerianRey
committed
Add missing tests of check_and_get_keys
ValerianRey
committed
revert cast to set in Select
PierreQuinton
committed
Remove check_keys_are
ValerianRey
committed
Remove useless casting to set in Select.check_and_get_keys
ValerianRey
committed
Add docstring to mtl_backward._create_transform
ValerianRey
committed
Rename _make_task_transform to _create_task_transform
ValerianRey
committed
Uniformize test_check_create_transform for backward and mtl_backward and make them assert the required and output keys are correct
ValerianRey
committed
Explicitly give parameter names in calls to _create_transform
ValerianRey
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Isolate key checks in transforms#279

Isolate key checks in transforms#279
ValerianRey merged 23 commits intomainfrom
decouple_construction_check_in_transforms

Commits on Mar 28, 2025

Decouple construction and checking in Transforms

add check_keys in test_stack.FakeGradientsTransform

Fix tests checking Transforms

remove test_call_checks_keys

Add changelog entry

Extract _create_transform from backward

Test _create_transform

Fix mtl_backward test of create transform and check keys

Remove _compute, use call instead

Same as before for FakeTransforms

Rename check_keys to check_and_get_keys

Improve docstring of check_and_get_keys

Fix tests of check_and_get_keys

Move check and cast to set from init to check_and_get_keys in Select

Change test_keys_check into test_check_and_get_keys in Select

Add missing tests of check_and_get_keys

revert cast to set in Select

Remove check_keys_are

Remove useless casting to set in Select.check_and_get_keys

Add docstring to mtl_backward._create_transform

Rename _make_task_transform to _create_task_transform

Uniformize test_check_create_transform for backward and mtl_backward and make them assert the required and output keys are correct

Explicitly give parameter names in calls to _create_transform