Merged
Conversation
PierreQuinton
added
package: aggregation
cc: refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
PierreQuinton
force-pushed
the
aggregastion-explicit-gramians
branch
from
b90928e to
13f38f2
Compare
PierreQuinton
changed the base branch from
main
to
change-gramian-normalization-to-frobenius-norm
PierreQuinton
force-pushed
the
aggregastion-explicit-gramians
branch
2 times, most recently
from
e32ad14 to
526681c
Compare
PierreQuinton
force-pushed
the
change-gramian-normalization-to-frobenius-norm
branch
from
ac8ddd3 to
ee06659
Compare
Base automatically changed from
change-gramian-normalization-to-frobenius-norm
to
main
April 10, 2025 11:56
PierreQuinton
force-pushed
the
aggregastion-explicit-gramians
branch
from
526681c to
e44d738
Compare
ValerianRey
reviewed
Apr 23, 2025
ValerianRey
reviewed
Apr 23, 2025
Contributor
|
I really like the way this is going: you're making internal changes that will make it much easier to make architectural changes! |
Contributor
|
This looks ready for a merge after my comments are resolved! Or is there more things you want to do? (I see this is still a draft PR). |
PierreQuinton
commented
Apr 25, 2025
PierreQuinton
commented
Apr 25, 2025
ValerianRey
approved these changes
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All aggregators can be computed from the Gramian except:
These commits makes this dependence explicit for all aggregators that do depend on the input matrix, for the rest (mean, sum, random and constant) it can obviously be done but computing the Gramian induces extra computations.