Skip to content

Improve ConFIG implementation#281

Merged
ValerianRey merged 5 commits intomainfrom
revamp-config
Apr 3, 2025
Merged

Improve ConFIG implementation#281
ValerianRey merged 5 commits intomainfrom
revamp-config

Conversation

@PierreQuinton
Copy link
Copy Markdown
Contributor

@PierreQuinton PierreQuinton commented Mar 30, 2025

  • Improve implementation of the matrix-vector product to simply use a single @.
  • Change the vector normalization to use torch.nn.functional.normalize with the default epsilon of 1e-12. This should change the output of the aggregator for very uncertain vectors to be zero instead.
  • Add changelog entry

@PierreQuinton PierreQuinton added package: aggregation cc: refactor Conventional commit type for any refactoring, not user-facing, and not typing or perf improvements labels Mar 30, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/torchjd/aggregation/config.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPU tests all pass.

@ValerianRey ValerianRey changed the title Revamp config Improve ConFIG implementation Apr 3, 2025
@ValerianRey ValerianRey merged commit f8e8a5e into main Apr 3, 2025
14 checks passed
@ValerianRey ValerianRey deleted the revamp-config branch April 3, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: refactor Conventional commit type for any refactoring, not user-facing, and not typing or perf improvements package: aggregation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants