Merged
Conversation
ValerianRey
added
package: autojac
cc: refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
…and test_conjunct_check_keys_2
PierreQuinton
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: originally, an idea was to have a method output_keys taking a set of keys as input and returning the output_keys given the provided input_keys (what check_keys does but without the check), and to have a requirement method taking a set of keys as input and returning a boolean as output (whether the given set of input satisfies the requirement of the transform or not). Even though this structure seems better in terms of single responsibility principle, it has the drawbacks of being inefficient, because the requirement method of a Composition would trigger the computation of the requirement method of the child + the computation of the output_keys method of the child. The number of method calls would thus scale quadratically with the number of transforms composed together. With the current structure, this does not happen, which makes it much more efficient with little-to-no downside.
TODO:
Add tests for new RequirementError messages and update the docstrings accordingly:
Also: