Skip to content

Make Aggregate typing more strict#289

Merged
ValerianRey merged 2 commits intomainfrom
improve-aggregate-typing
Mar 31, 2025
Merged

Make Aggregate typing more strict#289
ValerianRey merged 2 commits intomainfrom
improve-aggregate-typing

Conversation

@PierreQuinton
Copy link
Copy Markdown
Contributor

@PierreQuinton PierreQuinton commented Mar 31, 2025 •
edited by ValerianRey
Loading

  • Change type of key_order parameter of Aggregate and _AggregateMatrices from Iterable[Tensor] to OrderedSet[Tensor] and update tests accordingly

@PierreQuinton PierreQuinton added cc: test Conventional commit type for changes to tests. package: autojac labels Mar 31, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/torchjd/autojac/_transform/aggregate.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PierreQuinton PierreQuinton changed the title Improve Aggregate typing Fix Aggregate typing Mar 31, 2025
@ValerianRey ValerianRey changed the title Fix Aggregate typing Make Aggregate typing more strict Mar 31, 2025
@ValerianRey ValerianRey added cc: refactor Conventional commit type for any refactoring, not user-facing, and not typing or perf improvements and removed cc: test Conventional commit type for changes to tests. labels Mar 31, 2025
@ValerianRey ValerianRey merged commit a1658e2 into main Mar 31, 2025
14 checks passed
@ValerianRey ValerianRey deleted the improve-aggregate-typing branch March 31, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValerianRey ValerianRey ValerianRey approved these changes

Assignees

No one assigned

Labels

cc: refactor Conventional commit type for any refactoring, not user-facing, and not typing or perf improvements package: autojac

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PierreQuinton @ValerianRey