Skip to content

test: Ignore FutureWarning in test_lightning_integration#523

Merged
ValerianRey merged 2 commits intomainfrom
fix-lightning
Jan 21, 2026
Merged

test: Ignore FutureWarning in test_lightning_integration#523
ValerianRey merged 2 commits intomainfrom
fix-lightning

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey commented Jan 21, 2026

Something has changed either in torch or in lightning, but now a new warning can be raised by our lightning integration example, because they use a deprecated function. CI failed because of this: https://github.com/TorchJD/torchjd/actions/runs/21219633107/job/61050582119

@ValerianRey ValerianRey added the cc: test Conventional commit type for changes to tests. label Jan 21, 2026
@ValerianRey ValerianRey self-assigned this Jan 21, 2026
@claude
Copy link
Copy Markdown

claude bot commented Jan 21, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@ValerianRey ValerianRey changed the title test: Ignore FutureWarning in test_lightning_integration test: Ignore FutureWarning in test_lightning_integration Jan 21, 2026
@ValerianRey
Copy link
Copy Markdown
Contributor Author

@claude please merge this whenever checks are completed successfully.

@claude
Copy link
Copy Markdown

claude bot commented Jan 21, 2026

Claude finished @ValerianRey's task in 23s —— View job


CI Status Check

Good news! All CI checks have completed successfully:

  • Claude Code Review - passed
  • Check for TODOs - passed
  • Tests - passed

Unable to Merge

Unfortunately, I cannot merge pull requests due to my capabilities and permissions. Branch operations like merging are outside my scope.

Recommended Actions

You have a few options to merge this PR:

  1. Enable auto-merge: You can enable GitHub's auto-merge feature on this PR, which will automatically merge it once all required checks pass (they already have).

  2. Manual merge: You or another maintainer can merge the PR manually since all checks are green.

  3. More information: You can find more details about my capabilities and limitations in the FAQ.


@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValerianRey ValerianRey merged commit 711e778 into main Jan 21, 2026
15 checks passed
@ValerianRey ValerianRey deleted the fix-lightning branch January 21, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: test Conventional commit type for changes to tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant