Addressed Union type review

Author: regularkevvv

fastapi_gcp_tasks/requester.py

@@ -90,7 +90,7 @@ def _body(self, *, values: Dict[str, Any]) -> bytes | None:
                 got_body = body_field.get_default()
             body_type = body_field.field_info.annotation
             check_type = get_origin(body_type) or body_type
-            if body_type is not None and check_type is not None and not isinstance(got_body, check_type):
+            if body_type is not None and isinstance(check_type, type) and not isinstance(got_body, check_type):
                 raise WrongTypeError(field=body_field.name, type=body_type)
             body = json.dumps(jsonable_encoder(got_body)).encode()
         return body

tests/test_requester.py

@@ -1,7 +1,7 @@
 """Unit tests for Requester._body covering missing-param and generic-type bugs."""
 
 # Standard Library Imports
-from typing import List
+from typing import List, Union
 
 # Third Party Imports
 import pytest
@@ -38,6 +38,11 @@ async def list_body_endpoint(items: List[Item]) -> None:
     """Endpoint with a parameterized generic body."""
 
 
+@app.post("/union_body")
+async def union_body_endpoint(item: Union[Item, str] = "fallback") -> None:
+    """Endpoint with a Union-typed body."""
+
+
 def _get_route(path: str) -> APIRoute:
     for route in app.routes:
         if isinstance(route, APIRoute) and route.path == path:
@@ -88,3 +93,10 @@ def test_simple_body_wrong_type_raises(self) -> None:
         requester = Requester(route=route, base_url="http://localhost")
         with pytest.raises(WrongTypeError):
             requester._body(values={"item": "not an Item"})
+
+    def test_union_body_does_not_crash(self) -> None:
+        """Union-typed body should not raise TypeError on isinstance check."""
+        route = _get_route("/union_body")
+        requester = Requester(route=route, base_url="http://localhost")
+        body = requester._body(values={"item": Item(name="test")})
+        assert body is not None