[fix] SSL connections

[del[] SSL redundant options
[add] connection detailed error description

Author: i4004

src/EtcdTerminal.App/Screens/InstanceSelectionScreen.cs

@@ -21,7 +21,6 @@ public sealed class InstanceSelectionScreen(IConnectionConfigRepository _configR
 	private const string EnterInstanceName = "Enter instance name:";
 	private const string EnterConnStr = "Enter connection string:";
 	private const string DefaultConnStr = "http://localhost:2379";
-	private const string UseSsl = "Use SSL?";
 	private const string EnterUsername = "Enter username (optional, leave empty for none):";
 	private const string EnterPassword = "Enter password:";
 	private const string Connecting = "Connecting...";
@@ -58,11 +57,7 @@ await AnsiConsole.Status()
 						.StartAsync(Connecting, async ctx =>
 						{
 							await _etcdClient.ConnectAsync(selected);
-
-							var healthy = await _etcdClient.PingAsync();
-
-							if (!healthy)
-								throw new Exception("Server did not respond.");
+							await _etcdClient.PingAsync();
 						});
 
 					AnsiConsole.MarkupLine(ConnectedSuccess);
@@ -71,9 +66,8 @@ await AnsiConsole.Status()
 				}
 				catch (Exception ex)
 				{
-					AnsiConsole.MarkupLine($"[red]Failed to connect: {ex.Message}[/]");
+					AnsiConsole.MarkupLine($"[red]Failed to connect:[/] {ex.Message}");
 					AnsiConsole.WriteLine();
-
 					AnsiConsole.MarkupLine(Prompt.PressAnyKeyMarkup);
 					Console.ReadKey(true);
 				}
@@ -154,11 +148,6 @@ private void AddInstanceInteractive()
 			return;
 		}
 
-		var useSsl = Prompt.Confirm(UseSsl);
-
-		if (useSsl is null)
-			return;
-
 		var username = Prompt.Ask(EnterUsername);
 
 		if (username is null)
@@ -178,7 +167,6 @@ private void AddInstanceInteractive()
 		{
 			Name = name,
 			ConnectionString = connectionString,
-			UseSsl = useSsl.Value,
 			Username = string.IsNullOrEmpty(username) ? null : username,
 			Password = string.IsNullOrEmpty(password) ? null : password
 		};

src/EtcdTerminal.Infrastructure/Configuration/JsonBasedConfigRepository.cs

@@ -40,7 +40,6 @@ public IReadOnlyList<EtcdConnectionConfig> LoadInstances()
 						{
 							Name = i.GetProperty("Name").GetString() ?? string.Empty,
 							ConnectionString = i.GetProperty("ConnectionString").GetString() ?? string.Empty,
-							UseSsl = i.GetProperty("UseSsl").GetBoolean(),
 							Username = i.TryGetProperty("Username", out var u) ? u.GetString() : null,
 							Password = i.TryGetProperty("Password", out var p) ? p.GetString() : null,
 						};
@@ -102,7 +101,6 @@ private void SaveInstances(List<EtcdConnectionConfig> instances)
 			{
 				i.Name,
 				i.ConnectionString,
-				i.UseSsl,
 				i.Username,
 				i.Password
 			})

src/EtcdTerminal.Infrastructure/Etcd/DotnetEtcdBasedClient.cs

@@ -5,6 +5,7 @@
 using EtcdTerminal.Models;
 using Google.Protobuf;
 using Grpc.Core;
+using Grpc.Net.Client;
 using Mvccpb;
 
 namespace EtcdTerminal.Infrastructure.Etcd;
@@ -20,41 +21,30 @@ public Task ConnectAsync(EtcdConnectionConfig config, CancellationToken ct = def
 		Disconnect();
 
 		var connectionString = config.ConnectionString;
+		var useSsl = connectionString.StartsWith("https", StringComparison.OrdinalIgnoreCase);
 
-		if (config.IsAuthenticationEnabled)
+		void configureChannel(GrpcChannelOptions options)
 		{
-			_client = new EtcdClient(
-				connectionString,
-				config.Username,
-				config.Password);
-		}
-		else
-		{
-			_client = new EtcdClient(connectionString,
-				configureChannelOptions: options =>
-				{
-					if (!config.UseSsl)
-						options.Credentials = ChannelCredentials.Insecure;
-				});
+			options.Credentials = useSsl
+				? ChannelCredentials.SecureSsl
+				: ChannelCredentials.Insecure;
 		}
 
+		_client = config.IsAuthenticationEnabled
+			? new EtcdClient(connectionString, config.Username!, config.Password!,
+				configureChannelOptions: configureChannel)
+			: new EtcdClient(connectionString, configureChannelOptions: configureChannel);
+
 		return Task.CompletedTask;
 	}
 
 	public async Task<bool> PingAsync(CancellationToken ct = default)
 	{
 		if (_client is null) return false;
 
-		try
-		{
-			await _client!.GetAsync("\0", cancellationToken: ct);
+		await _client!.GetAsync("\0", cancellationToken: ct);
 
-			return true;
-		}
-		catch
-		{
-			return false;
-		}
+		return true;
 	}
 
 	public Task DisconnectAsync()

src/EtcdTerminal/Models/EtcdConnectionConfig.cs

@@ -4,7 +4,6 @@ public sealed class EtcdConnectionConfig
 {
 	public string Name { get; init; } = string.Empty;
 	public string ConnectionString { get; init; } = string.Empty;
-	public bool UseSsl { get; init; }
 	public string? Username { get; init; }
 	public string? Password { get; init; }
 	public bool IsAuthenticationEnabled => !string.IsNullOrEmpty(Username);