Feature/implement symfony http client#12
Draft
aaricdev wants to merge 40 commits into
Draft
Conversation
… objects (changed to string instead)
… objects (changed to string instead)
…lient' into feature/implement-symfony-http-client
- Still needs some work on DTOs and responses - Starts replacing JMS Serializer by Valinor
- !!! Still work in progress, code is currently broken, don't use !!!
- !!! Still work in progress, code is currently broken, don't use !!! - Still a bit rough around the edges. Maybe needs some kind of builder for Conditions/Subscriptions
- Implemented a lot of new subscriptions - still need some work, most of them are not usable at the moment
… currently existing with mocked data (based on real requests) - Deleted old DTOs, still need replacement on other places
- Also add github workflow
7ea6f22 to
0fe6308
Compare
- Also add github workflow
e2632c5 to
ad72a9b
Compare
- This bundle will use the HttpPlugClient from symfony/http-client
…fony - See https://github.com/Simply-Stream/TwitchApi - TODO: Change composer.json dependency to a version, currently it's bound to dev-main
… the core package
Contributor
|
Adding the return type Then in |
Member
Author
|
Looks good to me! |
Contributor
|
Also |
added 3 commits
June 4, 2024 17:10
… sadly don't have time to finish this up properly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still a lot to do here, but when this is finished, it might be considered v1.0