Skip to content

Feature/implement symfony http client#12

Draft
aaricdev wants to merge 40 commits into
developfrom
feature/implement-symfony-http-client
Draft

Feature/implement symfony http client#12
aaricdev wants to merge 40 commits into
developfrom
feature/implement-symfony-http-client

Conversation

@aaricdev

Copy link
Copy Markdown
Member

Still a lot to do here, but when this is finished, it might be considered v1.0

…lient' into feature/implement-symfony-http-client
- Still needs some work on DTOs and responses
- Starts replacing JMS Serializer by Valinor
- !!! Still work in progress, code is currently broken, don't use !!!
- !!! Still work in progress, code is currently broken, don't use !!!
- Still a bit rough around the edges. Maybe needs some kind of builder for Conditions/Subscriptions
- Implemented a lot of new subscriptions - still need some work, most of them are not usable at the moment
… currently existing with mocked data (based on real requests)

- Deleted old DTOs, still need replacement on other places
@aaricdev aaricdev self-assigned this Nov 12, 2023
@aaricdev aaricdev force-pushed the feature/implement-symfony-http-client branch 2 times, most recently from 7ea6f22 to 0fe6308 Compare November 14, 2023 19:28
@aaricdev aaricdev force-pushed the feature/implement-symfony-http-client branch from e2632c5 to ad72a9b Compare November 14, 2023 20:05
@enekochan

enekochan commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

Adding the return type void to SimplyStream\TwitchApiBundle\DependencyInjection\SimplyStreamTwitchApiExtension:load(...) removes a deprecation in Symfony 6.4 and this bundle should be compatible with Symfony 7.0.

class SimplyStreamTwitchApiExtension extends Extension
{
    /**
     * {@inheritDoc}
     */
    public function load(array $configs, ContainerBuilder $container): void
    {
        ...
    }
}

Then in composer.json packages for Symfony 6.2 could add 7.0:

{
    ...
    "require": {
        "php": "^8.2",
        "symfony/http-foundation": "^6.2|^7.0",
        "symfony/property-info": "^6.2|^7.0",
        "symfony/http-client": "^6.2|^7.0",
        "nyholm/psr7": "^1.5",
        "simply-stream/twitch-api": "dev-main"
    },
    "require-dev": {
        "phpunit/phpunit": "^9.5",
        "symfony/framework-bundle": "^6.2|^7.0",
        "symfony/yaml": "^6.3|^7.0",
        "phpstan/phpstan": "^1.10",
        "php-http/mock-client": "^1.6"
    },
    ...
}

@aaricdev

Copy link
Copy Markdown
Member Author

Looks good to me!
Will implement it later this week :)

@enekochan

Copy link
Copy Markdown
Contributor

Also "simply-stream/twitch-api": "dev-main" may be should point to a version like ^1.1, shouldn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants