Conversation
The 9.1.0 --no-auto-fetch opt-out was only wired through ReviewPROptions. summarizePr (pr.go) and summarizeDiff (navigation.go) still auto-fetched unconditionally, giving air-gapped callers inconsistent behavior across the three review-adjacent MCP tools. Add NoAutoFetch to both options structs; route through VerifyRef (local-only) instead of EnsureRef when set. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ckb_fresh is a dev-build binary that kept showing up as untracked; *.test catches Go test binaries like scip.test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🟢 Change Impact Analysis
Blast Radius: 0 modules, 0 files, 0 unique callers 📝 Changed Symbols (4)
Recommendations
Generated by CKB |
CKB Analysis
Risk factors: Touches 3 hotspot(s) 👥 Suggested: @lisa.welsch1985@gmail.com (100%), @talantyyr@gmail.com (50%), @lisa@tastehub.io (75%)
🎯 Change Impact Analysis · 🟢 LOW · 4 changed → 0 affected
Symbols changed in this PR:
Recommendations:
🔥 Hotspots · 3 volatile files
📊 Complexity · 2 violations
💡 Quick wins · 10 suggestions
📚 Stale docs · 197 broken references
Generated by CKB · Run details |
CKB Review: ✅ PASS — 100/1000 files (+0 changes) · 0 modules
|
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.0%) is below the target coverage (30.0%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #211 +/- ##
=======================================
Coverage 43.3% 43.3%
=======================================
Files 527 527
Lines 81317 81325 +8
=======================================
+ Hits 35232 35241 +9
- Misses 43612 43614 +2
+ Partials 2473 2470 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes two loose ends from the 9.0.1 / 9.1.0 shallow-CI-clone work.
--no-auto-fetch/ReviewPROptions.NoAutoFetch, butsummarizePr(pr.go) andsummarizeDiff(navigation.go) still auto-fetched unconditionally. Air-gapped MCP/HTTP callers now have a consistent opt-out across all three review-adjacent tools./ckb_freshand*.testto.gitignoreso local dev-build binaries and compiled Go test binaries in repo root stop showing as untracked.Details
SummarizePROptions.NoAutoFetch— when true, routes throughVerifyRef(local-only rev-parse check) instead ofEnsureRef(fetches on miss). Same pattern already used inreview.go.SummarizeDiffOptions.NoAutoFetch— applies to theCommitRangepath where user-supplied base/head refs are resolved. Other selectors (Commit,TimeWindow) operate on local SHAs so they're unaffected.No CLI flags added — these two tools are MCP/HTTP-only.
Test plan
go build ./...cleango test ./internal/query/ ./internal/backends/git/passesckb_fresh/scip.testno longer surface ingit statusnoAutoFetch: truefails cleanly on missing ref instead of fetching🤖 Generated with Claude Code