cifs: fix erroneous return value

aspsk · gregkh · commit 65b1cbfcc31b · 2016-02-25T11:57:48.000-08:00
commit 4b550af upstream. The setup_ntlmv2_rsp() function may return positive value ENOMEM instead of -ENOMEM in case of kmalloc failure. Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com> Signed-off-by: Steve French <smfrench@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
@@ -591,7 +591,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)
 
 	ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
 	if (!ses->auth_key.response) {
-		rc = ENOMEM;
+		rc = -ENOMEM;
 		ses->auth_key.len = 0;
 		goto setup_ntlmv2_rsp_ret;
 	}

Original file line number	Diff line number	Diff line change
`@@ -591,7 +591,7 @@ setup_ntlmv2_rsp(struct cifs_ses ses, const struct nls_table nls_cp)`
`591`	`591`
`592`	`592`	`ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);`
`593`	`593`	`if (!ses->auth_key.response) {`
`594`		`- rc = ENOMEM;`
	`594`	`+ rc = -ENOMEM;`
`595`	`595`	`ses->auth_key.len = 0;`
`596`	`596`	`goto setup_ntlmv2_rsp_ret;`
`597`	`597`	`}`