rocketjump fix: clamp velocity instead of hardcode to 0#898
Merged
Conversation
Owner
|
Not opposed, but replacing a hardcode with another hardcoded limit doesn't seem optimal. |
Contributor
Author
|
The number 242.29 is what line 107 output when testing a common jump on a 100 tick server. I suppose if someone wanted to change the jump velocity in their config this hardcoded value would be annoying. Ideally the value would be the same velocity you get when initiating a normal jump, not sure how to fetch that through the sourcemod api. The quick and dirty is good enough for my needs on ceda but if you want this to be cleaner feel free to close this request and make the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's bring jumping on commons back.