Restore default chat behavior while paused#905
Merged
Conversation
The problem is that `gpGlobals->curtime` doesn't change in pause, it's used by dataprop `m_fLastPlayerTalkTime`, so chat doesn't work during pause, previously the code in the plugin compensated for this, which changed the default game behavior, and all the code in the game function `Host_Say` was ignored, and some things, such as plugins intercepting the `player_say` event, did not work correctly. In fact, in this function `Host_Say`, there is a lot of code, much more than in plugin `pause`, for example adding a prefix to the message, formatting the text in the correct form, checking the validity of the message, creating event `player_say`, checking whether each player can hear you, etc. Some bugs for example: `HlstastsX` (used to collect stats and chat) did not collect chat stats. Plugins allowing to ignore another player could not work.
Owner
|
Good catch 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that
gpGlobals->curtimedoesn't change in pause, it's used by datapropm_fLastPlayerTalkTime, so chat doesn't work during pause, previously the code in the plugin compensated for this, which changed the default game behavior, and all the code in the game functionHost_Saywas ignored, and some things, such as plugins intercepting theplayer_sayevent, did not work correctly.In fact, in this function
Host_Say, there is a lot of code, much more than in pluginpause, for example:player_say,Some bugs for example:
HlstastsX(used to collect stats and chat) did not collect chat stats.