Merge pull request #40 Fixes regarding to copilot review

Krishanthaudayakumara · web-flow · commit 0275d1b2d790 · 2025-09-30T14:06:38.000+05:30
- use _ = _factory.Server; to clearly indicate the variable is intentionally 
- using the more modern collection expression syntax for consistency in EdgeSitemapProxyFixture
- Refactor RequestHeadersValidationFixture to implement similar constructor pattern like other fixtures
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/ComplexModelBindingFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/ComplexModelBindingFixture.cs
@@ -48,7 +48,7 @@ public ComplexModelBindingFixture(TestWebApplicationFactory<TestWebApplicationPr
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/CustomModelContextBindingFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/CustomModelContextBindingFixture.cs
@@ -49,7 +49,7 @@ public CustomModelContextBindingFixture(TestWebApplicationFactory<TestWebApplica
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/CustomResolverBindingFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/CustomResolverBindingFixture.cs
@@ -50,7 +50,7 @@ public CustomResolverBindingFixture(TestWebApplicationFactory<TestWebApplication
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/ModelBindingErrorHandlingFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/ModelBindingErrorHandlingFixture.cs
@@ -48,7 +48,7 @@ public ModelBindingErrorHandlingFixture(TestWebApplicationFactory<TestWebApplica
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/ViewFieldsBindingFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/ViewFieldsBindingFixture.cs
@@ -48,7 +48,7 @@ public ViewFieldsBindingFixture(TestWebApplicationFactory<TestWebApplicationProg
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/CustomRenderTypes/LoggingComponentRendererFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/CustomRenderTypes/LoggingComponentRendererFixture.cs
@@ -49,7 +49,7 @@ public LoggingComponentRendererFixture(TestWebApplicationFactory<TestWebApplicat
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/CustomRenderTypes/MultipleComponentsAddedFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/CustomRenderTypes/MultipleComponentsAddedFixture.cs
@@ -49,7 +49,7 @@ public MultipleComponentsAddedFixture(TestWebApplicationFactory<TestWebApplicati
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/CustomRenderTypes/PartialViewRendererFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/CustomRenderTypes/PartialViewRendererFixture.cs
@@ -48,7 +48,7 @@ public PartialViewRendererFixture(TestWebApplicationFactory<TestWebApplicationPr
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Pages/PagesEditingFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Pages/PagesEditingFixture.cs
@@ -63,7 +63,7 @@ public PagesEditingFixture(TestWebApplicationFactory<TestWebApplicationProgram>
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Pages/PagesSetupRoutingFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Pages/PagesSetupRoutingFixture.cs
@@ -57,7 +57,7 @@ public PagesSetupRoutingFixture(TestWebApplicationFactory<TestWebApplicationProg
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/RequestHeadersValidationFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/RequestHeadersValidationFixture.cs
@@ -11,16 +11,22 @@
 
 namespace Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests.Fixtures;
 
-public class RequestHeadersValidationFixture(TestWebApplicationFactory<TestWebApplicationProgram> factory) : IClassFixture<TestWebApplicationFactory<TestWebApplicationProgram>>, IDisposable
+public class RequestHeadersValidationFixture : IClassFixture<TestWebApplicationFactory<TestWebApplicationProgram>>, IDisposable
 {
+    private readonly TestWebApplicationFactory<TestWebApplicationProgram> _factory;
     private MockHttpMessageHandler _clientHandler = new();
     private WebApplicationFactory<TestWebApplicationProgram> _appFactory = null!;
 
+    public RequestHeadersValidationFixture(TestWebApplicationFactory<TestWebApplicationProgram> factory)
+    {
+        _factory = factory;
+    }
+
     [Fact]
     public async Task Request_WithNonValidatedHeaders_HeadersAreProperlyValidated()
     {
         // Arrange
-        _appFactory = BuildRequestHeadersWebApplicationFactory(new[] { "User-Agent" });
+        _appFactory = BuildRequestHeadersWebApplicationFactory(["User-Agent"]);
         ISitecoreLayoutClient layoutClient = _appFactory.Services.GetRequiredService<ISitecoreLayoutClient>();
 
         SitecoreLayoutRequest request = new SitecoreLayoutRequest()
@@ -71,7 +77,7 @@ private WebApplicationFactory<TestWebApplicationProgram> BuildRequestHeadersWebA
             { "User-Agent", ["site;core"] }
         };
 
-        return factory.WithWebHostBuilder(builder =>
+        return _factory.WithWebHostBuilder(builder =>
         {
             builder.ConfigureServices(services =>
             {
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/SearchOptimization/EdgeSitemapProxyFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/SearchOptimization/EdgeSitemapProxyFixture.cs
@@ -46,7 +46,7 @@ public EdgeSitemapProxyFixture(TestWebApplicationFactory<TestWebApplicationProgr
                             {
                                 SiteInfo = new SiteInfo
                                 {
-                                    Sitemap = new[] { _edgeSitemapUrl.ToString() }
+                                    Sitemap = [_edgeSitemapUrl.ToString()]
                                 }
                             }
                         }
@@ -69,7 +69,7 @@ public EdgeSitemapProxyFixture(TestWebApplicationFactory<TestWebApplicationProgr
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/SearchOptimization/SitemapProxyFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/SearchOptimization/SitemapProxyFixture.cs
@@ -42,7 +42,7 @@ public SitemapProxyFixture(TestWebApplicationFactory<TestWebApplicationProgram>
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/AllFieldTagHelpersFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/AllFieldTagHelpersFixture.cs
@@ -50,7 +50,7 @@ public AllFieldTagHelpersFixture(TestWebApplicationFactory<TestWebApplicationPro
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/DateFieldTagHelperFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/DateFieldTagHelperFixture.cs
@@ -49,7 +49,7 @@ public DateFieldTagHelperFixture(TestWebApplicationFactory<TestWebApplicationPro
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/FileFieldTagHelperFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/FileFieldTagHelperFixture.cs
@@ -50,7 +50,7 @@ public FileFieldTagHelperFixture(TestWebApplicationFactory<TestWebApplicationPro
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/ImageFieldTagHelperFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/ImageFieldTagHelperFixture.cs
@@ -54,7 +54,7 @@ public ImageFieldTagHelperFixture(TestWebApplicationFactory<TestWebApplicationPr
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/LinkFieldTagHelperFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/LinkFieldTagHelperFixture.cs
@@ -50,7 +50,7 @@ public LinkFieldTagHelperFixture(TestWebApplicationFactory<TestWebApplicationPro
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/NumberFieldTagHelperFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/NumberFieldTagHelperFixture.cs
@@ -51,7 +51,7 @@ public NumberFieldTagHelperFixture(TestWebApplicationFactory<TestWebApplicationP
 
         // ensure host started so services are available and analyzers are happy
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/PlaceholderTagHelperFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/PlaceholderTagHelperFixture.cs
@@ -49,7 +49,7 @@ public PlaceholderTagHelperFixture(TestWebApplicationFactory<TestWebApplicationP
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]
diff --git a/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/RichTextFieldTagHelperFixture.cs b/tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/RichTextFieldTagHelperFixture.cs
@@ -50,7 +50,7 @@ public RichTextFieldTagHelperFixture(TestWebApplicationFactory<TestWebApplicatio
         });
 
         // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
-        TestServer startedServer = _factory.Server;
+        _ = _factory.Server;
     }
 
     [Fact]

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public ComplexModelBindingFixture(TestWebApplicationFactory<TestWebApplicationPr`
`48`	`48`	`});`
`49`	`49`
`50`	`50`	`// Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.`
`51`		`- TestServer startedServer = _factory.Server;`
	`51`	`+ _ = _factory.Server;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public CustomModelContextBindingFixture(TestWebApplicationFactory<TestWebApplica`
`49`	`49`	`});`
`50`	`50`
`51`	`51`	`// Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.`
`52`		`- TestServer startedServer = _factory.Server;`
	`52`	`+ _ = _factory.Server;`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public CustomResolverBindingFixture(TestWebApplicationFactory<TestWebApplication`
`50`	`50`	`});`
`51`	`51`
`52`	`52`	`// Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.`
`53`		`- TestServer startedServer = _factory.Server;`
	`53`	`+ _ = _factory.Server;`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public ModelBindingErrorHandlingFixture(TestWebApplicationFactory<TestWebApplica`
`48`	`48`	`});`
`49`	`49`
`50`	`50`	`// Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.`
`51`		`- TestServer startedServer = _factory.Server;`
	`51`	`+ _ = _factory.Server;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public ViewFieldsBindingFixture(TestWebApplicationFactory<TestWebApplicationProg`
`48`	`48`	`});`
`49`	`49`
`50`	`50`	`// Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.`
`51`		`- TestServer startedServer = _factory.Server;`
	`51`	`+ _ = _factory.Server;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public LoggingComponentRendererFixture(TestWebApplicationFactory<TestWebApplicat`
`49`	`49`	`});`
`50`	`50`
`51`	`51`	`// Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.`
`52`		`- TestServer startedServer = _factory.Server;`
	`52`	`+ _ = _factory.Server;`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public MultipleComponentsAddedFixture(TestWebApplicationFactory<TestWebApplicati`
`49`	`49`	`});`
`50`	`50`
`51`	`51`	`// Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.`
`52`		`- TestServer startedServer = _factory.Server;`
	`52`	`+ _ = _factory.Server;`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public PartialViewRendererFixture(TestWebApplicationFactory<TestWebApplicationPr`
`48`	`48`	`});`
`49`	`49`
`50`	`50`	`// Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.`
`51`		`- TestServer startedServer = _factory.Server;`
	`51`	`+ _ = _factory.Server;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public PagesEditingFixture(TestWebApplicationFactory<TestWebApplicationProgram>`
`63`	`63`	`});`
`64`	`64`
`65`	`65`	`// Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.`
`66`		`- TestServer startedServer = _factory.Server;`
	`66`	`+ _ = _factory.Server;`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public PagesSetupRoutingFixture(TestWebApplicationFactory<TestWebApplicationProg`
`57`	`57`	`});`
`58`	`58`
`59`	`59`	`// Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.`
`60`		`- TestServer startedServer = _factory.Server;`
	`60`	`+ _ = _factory.Server;`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`[Fact]`