Changed text based TagHelpers to rendering Chromes with internal span not div

Author: robearlam

src/Sitecore.AspNetCore.SDK.RenderingEngine/TagHelpers/Fields/RichTextTagHelper.cs

@@ -55,7 +55,7 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
         if (Editable && richTextField.OpeningChrome != null)
         {
             html += _chromeRenderer.Render(richTextField.OpeningChrome);
-            html += "<div>";
+            html += "<span>";
         }
 
         bool outputEditableMarkup = Editable && !string.IsNullOrEmpty(richTextField.EditableMarkup);
@@ -65,7 +65,7 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
 
         if (Editable && richTextField.ClosingChrome != null)
         {
-            html += "</div>";
+            html += "</span>";
             html += _chromeRenderer.Render(richTextField.ClosingChrome);
         }
 

src/Sitecore.AspNetCore.SDK.RenderingEngine/TagHelpers/Fields/TextFieldTagHelper.cs

@@ -51,7 +51,7 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
         if (Editable && field.OpeningChrome != null)
         {
             html += _chromeRenderer.Render(field.OpeningChrome);
-            html += "<div>";
+            html += "<span>";
             isHtml = true;
         }
 
@@ -67,7 +67,7 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
 
         if (Editable && field.ClosingChrome != null)
         {
-            html += "</div>";
+            html += "</span>";
             html += _chromeRenderer.Render(field.ClosingChrome);
         }
 

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Tests/TagHelpers/Fields/RichTextTagHelperFixture.cs

@@ -1,6 +1,4 @@
-using System.Diagnostics.CodeAnalysis;
-using System.Globalization;
-using AutoFixture;
+using AutoFixture;
 using AutoFixture.Idioms;
 using FluentAssertions;
 using Microsoft.AspNetCore.Mvc.ModelBinding;
@@ -14,6 +12,9 @@
 using Sitecore.AspNetCore.SDK.LayoutService.Client.Response.Model.Fields;
 using Sitecore.AspNetCore.SDK.RenderingEngine.Rendering;
 using Sitecore.AspNetCore.SDK.RenderingEngine.TagHelpers.Fields;
+using System.Diagnostics.CodeAnalysis;
+using System.Globalization;
+using System.Text.Encodings.Web;
 using Xunit;
 
 namespace Sitecore.AspNetCore.SDK.RenderingEngine.Tests.TagHelpers.Fields;
@@ -733,6 +734,7 @@ public void Process_RenderingChromesAreNotNull_ChromesAreOutput(
         // Assert
         chromeRenderer.Received().Render(openingChrome);
         chromeRenderer.Received().Render(closingChrome);
+        tagHelperOutput.Content.GetContent().Should().Be($"{chromeRenderer.Render(openingChrome)}<span>{TestHtml}</span>{chromeRenderer.Render(closingChrome)}");
     }
 
     private static ModelExpression GetModelExpression(Field model)

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Tests/TagHelpers/Fields/TextFieldTagHelperFixture.cs

@@ -214,6 +214,7 @@ public void Process_RenderingChromesAreNotNull_ChromesAreOutput(
         // Assert
         chromeRenderer.Received().Render(openingChrome);
         chromeRenderer.Received().Render(closingChrome);
+        tagHelperOutput.Content.GetContent().Should().Be($"{chromeRenderer.Render(openingChrome)}<span>{TestText}</span>{chromeRenderer.Render(closingChrome)}");
     }
 
     private static IEnumerable<object[]> GetModelExpressionTestData()