Skip to content

Commit 1af1068

Browse files
committed
Removed ID property from EdtiableField as didnt need to be added
1 parent ac8a933 commit 1af1068

2 files changed

Lines changed: 6 additions & 13 deletions

File tree

src/Sitecore.AspNetCore.SDK.LayoutService.Client/Response/Model/EditableField.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,6 @@ public class EditableField<TValue>
1515
[JsonPropertyName("editable")]
1616
public string EditableMarkup { get; set; } = string.Empty;
1717

18-
/// <summary>
19-
/// Gets or Sets the id of the Field.
20-
/// </summary>
21-
[DataMember(Name = "Id")]
22-
[JsonPropertyName("Id")]
23-
public string Id { get; set; } = string.Empty;
24-
2518
/// <inheritdoc />
2619
public EditableChrome? OpeningChrome { get; set; }
2720

tests/Sitecore.AspNetCore.SDK.LayoutService.Client.Tests/Serialization/Converter/FieldConverterTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ public class FieldConverterTests
1717

1818
public static TheoryData<IFieldReader, string> Fields => new()
1919
{
20-
{ new TextField("Test"), """{"editable":"","Id":"","value":"Test"}""" },
21-
{ new RichTextField("Test Noencoding", false), """{"editable":"","Id":"","value":"Test Noencoding"}""" },
22-
{ new RichTextField("Test%20Encoded"), """{"editable":"","Id":"","value":"Test Encoded"}""" },
23-
{ new CheckboxField(true), """{"editable":"","Id":"","value":true}""" },
24-
{ new CheckboxField(false), """{"editable":"","Id":""}""" },
25-
{ new ImageField(new Image { Alt = "Alt Text", Border = 1, Class = "styleclass", HSpace = 1, Height = 100, Src = "https://image.com/test.jpg", Title = "Title", VSpace = 1, Width = 100 }), """{"editable":"","Id":"","value":{"src":"https://image.com/test.jpg","alt":"Alt Text","height":"100","width":"100","title":"Title","hSpace":"1","vSpace":"1","border":"1","class":"styleclass"}}""" }
20+
{ new TextField("Test"), """{"editable":"","value":"Test"}""" },
21+
{ new RichTextField("Test Noencoding", false), """{"editable":"","value":"Test Noencoding"}""" },
22+
{ new RichTextField("Test%20Encoded"), """{"editable":"","value":"Test Encoded"}""" },
23+
{ new CheckboxField(true), """{"editable":"","value":true}""" },
24+
{ new CheckboxField(false), """{"editable":""}""" },
25+
{ new ImageField(new Image { Alt = "Alt Text", Border = 1, Class = "styleclass", HSpace = 1, Height = 100, Src = "https://image.com/test.jpg", Title = "Title", VSpace = 1, Width = 100 }), """{"editable":"","value":{"src":"https://image.com/test.jpg","alt":"Alt Text","height":"100","width":"100","title":"Title","hSpace":"1","vSpace":"1","border":"1","class":"styleclass"}}""" }
2626
};
2727

2828
[Fact]

0 commit comments

Comments
 (0)