Skip to content

Commit 21d8af3

Browse files
extract the duplicated URL prefix replacement logic into a separate method - ApplyJssMediaUrlPrefix
1 parent 10c272a commit 21d8af3

1 file changed

Lines changed: 11 additions & 8 deletions

File tree

src/Sitecore.AspNetCore.SDK.RenderingEngine/Extensions/SitecoreFieldExtensions.cs

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,7 @@ private static string GetSitecoreMediaUri(string url, object? imageParams)
130130
}
131131
}
132132

133-
// TODO Review hardcoded matching and replacement
134-
Match match = MediaUrlPrefixRegex().Match(url);
135-
if (match.Success)
136-
{
137-
url = url.Replace(match.Value, $"/{match.Groups[1]}/jssmedia/", StringComparison.InvariantCulture);
138-
}
139-
140-
return url;
133+
return ApplyJssMediaUrlPrefix(url);
141134
}
142135

143136
/// <summary>
@@ -210,6 +203,16 @@ private static string GetSitecoreMediaUriWithPreservation(string urlStr, object?
210203
}
211204
}
212205

206+
return ApplyJssMediaUrlPrefix(url);
207+
}
208+
209+
/// <summary>
210+
/// Applies JSS media URL prefix replacement to the given URL.
211+
/// </summary>
212+
/// <param name="url">The URL to transform.</param>
213+
/// <returns>The URL with JSS media prefix applied if applicable.</returns>
214+
private static string ApplyJssMediaUrlPrefix(string url)
215+
{
213216
// TODO Review hardcoded matching and replacement
214217
Match match = MediaUrlPrefixRegex().Match(url);
215218
if (match.Success)

0 commit comments

Comments
 (0)