Skip to content

Commit 3184370

Browse files
Ensure we only drop the path when URI parsing succeedsin GetSitecoreMediaUriWithPreservation
1 parent be01987 commit 3184370

1 file changed

Lines changed: 19 additions & 16 deletions

File tree

src/Sitecore.AspNetCore.SDK.RenderingEngine/Extensions/SitecoreFieldExtensions.cs

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -142,36 +142,39 @@ private static string GetSitecoreMediaUri(string url, object? imageParams)
142142
{
143143
string? url;
144144

145-
if (urlStr == null)
145+
if (string.IsNullOrEmpty(urlStr))
146146
{
147-
url = null;
148-
}
149-
else if (string.IsNullOrEmpty(urlStr))
150-
{
151-
url = string.Empty;
147+
url = urlStr;
152148
}
153149
else
154150
{
155151
// Parse existing query parameters and build merged parameters dictionary
156152
Dictionary<string, object?> mergedParams = new(StringComparer.OrdinalIgnoreCase);
157-
Uri.TryCreate(urlStr, UriKind.RelativeOrAbsolute, out Uri? uri);
158153

159-
url = ParseUrlParams(uri, mergedParams);
154+
if (!Uri.TryCreate(urlStr, UriKind.RelativeOrAbsolute, out Uri? uri))
155+
{
156+
url = urlStr;
157+
}
158+
else
159+
{
160+
url = ParseUrlParams(uri, mergedParams);
160161

161-
// Add new parameters (these will override existing ones)
162-
AddParametersToResult(mergedParams, parameters, skipNullValues: true);
162+
// Add new parameters (these will override existing ones)
163+
AddParametersToResult(mergedParams, parameters, skipNullValues: true);
163164

164-
// Add query parameters
165-
foreach (KeyValuePair<string, object?> kvp in mergedParams)
166-
{
167-
if (kvp.Value != null)
165+
// Add query parameters
166+
foreach (KeyValuePair<string, object?> kvp in mergedParams)
168167
{
169-
url = QueryHelpers.AddQueryString(url, kvp.Key, kvp.Value.ToString() ?? string.Empty);
168+
if (kvp.Value != null)
169+
{
170+
url = QueryHelpers.AddQueryString(url, kvp.Key, kvp.Value.ToString() ?? string.Empty);
171+
}
170172
}
171173
}
172174
}
173175

174-
return url == null ? null : ApplyJssMediaUrlPrefix(url);
176+
string? result = url == null ? null : ApplyJssMediaUrlPrefix(url);
177+
return result;
175178
}
176179

177180
/// <summary>

0 commit comments

Comments
 (0)