Changed to no longer persist component names for predicate registrations as its not supported by MetaData Editing

Author: robearlam

src/Sitecore.AspNetCore.SDK.Pages/Controllers/PagesSetupController.cs

@@ -91,7 +91,7 @@ private PagesConfigResponse BuildConfigResponseBody()
             return new PagesConfigResponse
             {
                 EditMode = "metadata",
-                Components = renderingEngineOptions.RendererRegistry.Select(x => x.Value.ComponentName).ToList()
+                Components = renderingEngineOptions.RendererRegistry.Where(x => x.Value.ComponentName != string.Empty).Select(x => x.Value.ComponentName).ToList()
             };
         }
 

src/Sitecore.AspNetCore.SDK.RenderingEngine/Extensions/RenderingEngineOptionsExtensions.cs

@@ -151,7 +151,7 @@ public static RenderingEngineOptions AddViewComponent(
         ArgumentNullException.ThrowIfNull(match);
         ArgumentException.ThrowIfNullOrWhiteSpace(viewComponentName);
 
-        ComponentRendererDescriptor descriptor = ViewComponentComponentRenderer.Describe(match, viewComponentName, viewComponentName);
+        ComponentRendererDescriptor descriptor = ViewComponentComponentRenderer.Describe(match, viewComponentName);
 
         options.RendererRegistry.Add(options.RendererRegistry.Count, descriptor);
 

src/Sitecore.AspNetCore.SDK.RenderingEngine/Rendering/ComponentRendererDescriptor.cs

@@ -8,10 +8,11 @@
 /// </remarks>
 /// <param name="match">The predicate to use when retrieving a <see cref="IComponentRenderer"/>.</param>
 /// <param name="factory">The factory method to create a new instance of the <see cref="IComponentRenderer"/>.</param>
+/// <param name="componentName">The name of the component being added.</param>
 public class ComponentRendererDescriptor(
     Predicate<string> match,
     Func<IServiceProvider, IComponentRenderer> factory,
-    string componentName)
+    string componentName = "")
 {
     private readonly Func<IServiceProvider, IComponentRenderer> _factory = factory ?? throw new ArgumentNullException(nameof(factory));
     private readonly object _lock = new();

src/Sitecore.AspNetCore.SDK.RenderingEngine/Rendering/LoggingComponentRenderer.cs

@@ -31,8 +31,7 @@ public static ComponentRendererDescriptor Describe(Predicate<string> match)
 
         return new ComponentRendererDescriptor(
             match,
-            sp => ActivatorUtilities.CreateInstance<LoggingComponentRenderer>(sp),
-            string.Empty);
+            sp => ActivatorUtilities.CreateInstance<LoggingComponentRenderer>(sp));
     }
 
     /// <inheritdoc />

src/Sitecore.AspNetCore.SDK.RenderingEngine/Rendering/PartialViewComponentRenderer.cs

@@ -35,8 +35,7 @@ public static ComponentRendererDescriptor Describe(Predicate<string> match, stri
         ArgumentException.ThrowIfNullOrWhiteSpace(locator);
         return new ComponentRendererDescriptor(
             match,
-            sp => ActivatorUtilities.CreateInstance<PartialViewComponentRenderer>(sp, locator),
-            locator);
+            sp => ActivatorUtilities.CreateInstance<PartialViewComponentRenderer>(sp, locator));
     }
 
     /// <inheritdoc />

src/Sitecore.AspNetCore.SDK.RenderingEngine/Rendering/ViewComponentComponentRenderer.cs

@@ -31,11 +31,10 @@ public ViewComponentComponentRenderer(string locator)
     /// <param name="locator">The string to use when locating the View Component.</param>
     /// <param name="componentName">The string to use describe the name of the components.</param>
     /// <returns>An instance of <see cref="ComponentRendererDescriptor"/>.</returns>
-    public static ComponentRendererDescriptor Describe(Predicate<string> match, string locator, string componentName)
+    public static ComponentRendererDescriptor Describe(Predicate<string> match, string locator, string componentName = "")
     {
         ArgumentNullException.ThrowIfNull(match);
         ArgumentException.ThrowIfNullOrWhiteSpace(locator);
-        ArgumentException.ThrowIfNullOrWhiteSpace(componentName);
 
         return new ComponentRendererDescriptor(
             match,