Merge pull request #39 - Fixes regarding to Copilot reviews

- use app.Start() in TestWebApplicationProgram
- Add comment explaining variable startedServer
- Use the same layout-service builder pattern previously used in TrackingBenchmarks

Author: Krishanthaudayakumara

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Benchmarks/TrackingBenchmarks.cs

@@ -8,6 +8,7 @@
 using Microsoft.Extensions.DependencyInjection;
 using Sitecore.AspNetCore.SDK.AutoFixture.Mocks;
 using Sitecore.AspNetCore.SDK.LayoutService.Client.Extensions;
+using Sitecore.AspNetCore.SDK.LayoutService.Client.Interfaces;
 using Sitecore.AspNetCore.SDK.RenderingEngine.Extensions;
 using Sitecore.AspNetCore.SDK.TestData;
 using Sitecore.AspNetCore.SDK.Tracking;
@@ -42,8 +43,11 @@ public void TrackingBenchmarksSetup()
                                                    ForwardedHeaders.XForwardedProto;
                     });
 
-                    services.AddSitecoreLayoutService();
-                    services.AddHttpClient("mock").ConfigurePrimaryHttpMessageHandler(() => _mockClientHandler!);
+                    ISitecoreLayoutClientBuilder layoutBuilder = services.AddSitecoreLayoutService();
+                    layoutBuilder
+                        .AddHttpHandler("mock", _ => new HttpClient(_mockClientHandler!) { BaseAddress = new Uri("http://layout.service") })
+                        .AsDefaultHandler();
+
                     services.AddSitecoreRenderingEngine(options =>
                     {
                         options.AddDefaultComponentRenderer();

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/ComplexModelBindingFixture.cs

@@ -47,6 +47,7 @@ public ComplexModelBindingFixture(TestWebApplicationFactory<TestWebApplicationPr
             });
         });
 
+        // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
         TestServer startedServer = _factory.Server;
     }
 

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/CustomModelContextBindingFixture.cs

@@ -48,6 +48,7 @@ public CustomModelContextBindingFixture(TestWebApplicationFactory<TestWebApplica
             });
         });
 
+        // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
         TestServer startedServer = _factory.Server;
     }
 

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/CustomResolverBindingFixture.cs

@@ -49,6 +49,7 @@ public CustomResolverBindingFixture(TestWebApplicationFactory<TestWebApplication
             });
         });
 
+        // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
         TestServer startedServer = _factory.Server;
     }
 

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/ModelBindingErrorHandlingFixture.cs

@@ -47,6 +47,7 @@ public ModelBindingErrorHandlingFixture(TestWebApplicationFactory<TestWebApplica
             });
         });
 
+        // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
         TestServer startedServer = _factory.Server;
     }
 

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Binding/ViewFieldsBindingFixture.cs

@@ -47,6 +47,7 @@ public ViewFieldsBindingFixture(TestWebApplicationFactory<TestWebApplicationProg
             });
         });
 
+        // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
         TestServer startedServer = _factory.Server;
     }
 

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/CustomRenderTypes/LoggingComponentRendererFixture.cs

@@ -48,6 +48,7 @@ public LoggingComponentRendererFixture(TestWebApplicationFactory<TestWebApplicat
             });
         });
 
+        // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
         TestServer startedServer = _factory.Server;
     }
 

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/CustomRenderTypes/MultipleComponentsAddedFixture.cs

@@ -48,6 +48,7 @@ public MultipleComponentsAddedFixture(TestWebApplicationFactory<TestWebApplicati
             });
         });
 
+        // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
         TestServer startedServer = _factory.Server;
     }
 

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/CustomRenderTypes/PartialViewRendererFixture.cs

@@ -47,6 +47,7 @@ public PartialViewRendererFixture(TestWebApplicationFactory<TestWebApplicationPr
             });
         });
 
+        // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
         TestServer startedServer = _factory.Server;
     }
 

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/Pages/PagesEditingFixture.cs

@@ -62,6 +62,7 @@ public PagesEditingFixture(TestWebApplicationFactory<TestWebApplicationProgram>
             });
         });
 
+        // Accessing _factory.Server forces the TestServer to start. The variable is unused; this is intentional.
         TestServer startedServer = _factory.Server;
     }