Merge pull request #2958 from stefannikolei/sn/ref/target_type_new

Use Target Type new only when apparent

Author: JimBobSquarePants

.editorconfig

@@ -161,6 +161,9 @@ csharp_style_deconstructed_variable_declaration = true:warning
 csharp_style_prefer_index_operator = true:warning
 csharp_style_prefer_range_operator = true:warning
 csharp_style_implicit_object_creation_when_type_is_apparent = true:error
+# ReSharper inspection severities
+resharper_arrange_object_creation_when_type_evident_highlighting = error
+resharper_arrange_object_creation_when_type_not_evident_highlighting = error
 # "Null" checking preferences
 csharp_style_throw_expression = true:warning
 csharp_style_conditional_delegate_call = true:warning

shared-infrastructure

@@ -79,7 +79,7 @@ public ParallelExecutionSettings MultiplyMinimumPixelsPerTask(int multiplier)
     {
         Guard.MustBeGreaterThan(multiplier, 0, nameof(multiplier));
 
-        return new(
+        return new ParallelExecutionSettings(
             this.MaxDegreeOfParallelism,
             this.MinimumPixelsProcessedPerTask * multiplier,
             this.MemoryAllocator);
@@ -92,6 +92,6 @@ public ParallelExecutionSettings MultiplyMinimumPixelsPerTask(int multiplier)
     /// <returns>The <see cref="ParallelExecutionSettings"/>.</returns>
     public static ParallelExecutionSettings FromConfiguration(Configuration configuration)
     {
-        return new(configuration.MaxDegreeOfParallelism, configuration.MemoryAllocator);
+        return new ParallelExecutionSettings(configuration.MaxDegreeOfParallelism, configuration.MemoryAllocator);
     }
 }

src/ImageSharp/Advanced/ParallelExecutionSettings.cs

@@ -139,7 +139,7 @@ public void Invoke(int i)
             }
 
             int yMax = Math.Min(yMin + this.stepY, this.maxY);
-            RowInterval rows = new RowInterval(yMin, yMax);
+            RowInterval rows = new(yMin, yMax);
 
             // Skip the safety copy when invoking a potentially impure method on a readonly field
             Unsafe.AsRef(in this.operation).Invoke(in rows);
@@ -185,7 +185,7 @@ public void Invoke(int i)
             }
 
             int yMax = Math.Min(yMin + this.stepY, this.maxY);
-            RowInterval rows = new RowInterval(yMin, yMax);
+            RowInterval rows = new(yMin, yMax);
 
             using IMemoryOwner<TBuffer> buffer = this.allocator.Allocate<TBuffer>(this.bufferLength);
 

src/ImageSharp/Advanced/ParallelRowIterator.Wrappers.cs

@@ -8,7 +8,7 @@ namespace SixLabors.ImageSharp;
 /// </content>
 public partial struct Color
 {
-    private static readonly Lazy<Color[]> WernerPaletteLazy = new Lazy<Color[]>(CreateWernerPalette, true);
+    private static readonly Lazy<Color[]> WernerPaletteLazy = new(CreateWernerPalette, true);
 
     /// <summary>
     /// Gets a collection of colors as defined in the original second edition of Werner’s Nomenclature of Colours 1821.

src/ImageSharp/Color/Color.WernerPalette.cs

@@ -81,10 +81,10 @@ public static Color FromPixel<TPixel>(TPixel source)
         PixelTypeInfo info = TPixel.GetPixelTypeInfo();
         if (info.ComponentInfo.HasValue && info.ComponentInfo.Value.GetMaximumComponentPrecision() <= (int)PixelComponentBitDepth.Bit32)
         {
-            return new(source.ToScaledVector4());
+            return new Color(source.ToScaledVector4());
         }
 
-        return new(source);
+        return new Color(source);
     }
 
     /// <summary>
@@ -120,7 +120,7 @@ public static void FromPixel<TPixel>(ReadOnlySpan<TPixel> source, Span<Color> de
         {
             for (int i = 0; i < destination.Length; i++)
             {
-                destination[i] = new(source[i]);
+                destination[i] = new Color(source[i]);
             }
         }
     }

src/ImageSharp/Color/Color.cs

@@ -88,7 +88,7 @@ public Vector4 ToScaledVector4()
         v3 += this.AsVector3Unsafe();
         v3 += new Vector3(0, 128F, 128F);
         v3 /= new Vector3(100F, 255F, 255F);
-        return new(v3, 1F);
+        return new Vector4(v3, 1F);
     }
 
     /// <inheritdoc/>
@@ -97,7 +97,7 @@ public static CieLab FromScaledVector4(Vector4 source)
         Vector3 v3 = source.AsVector3();
         v3 *= new Vector3(100F, 255, 255);
         v3 -= new Vector3(0, 128F, 128F);
-        return new(v3);
+        return new CieLab(v3);
     }
 
     /// <inheritdoc/>
@@ -145,7 +145,7 @@ public static CieLab FromProfileConnectingSpace(ColorConversionOptions options,
         float a = 500F * (fx - fy);
         float b = 200F * (fy - fz);
 
-        return new(l, a, b);
+        return new CieLab(l, a, b);
     }
 
     /// <inheritdoc/>
@@ -182,7 +182,7 @@ public CieXyz ToProfileConnectingSpace(ColorConversionOptions options)
         Vector3 wxyz = new(whitePoint.X, whitePoint.Y, whitePoint.Z);
         Vector3 xyzr = new(xr, yr, zr);
 
-        return new(xyzr * wxyz);
+        return new CieXyz(xyzr * wxyz);
     }
 
     /// <inheritdoc/>

src/ImageSharp/ColorProfiles/CieLab.cs

@@ -25,7 +25,7 @@ namespace SixLabors.ImageSharp.ColorProfiles;
     /// <param name="h">The hue in degrees.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public CieLch(float l, float c, float h)
-        : this(new(l, c, h))
+        : this(new Vector3(l, c, h))
     {
     }
 
@@ -100,7 +100,7 @@ public Vector4 ToScaledVector4()
         v3 += this.AsVector3Unsafe();
         v3 += new Vector3(0, 200, 0);
         v3 /= new Vector3(100, 400, 360);
-        return new(v3, 1F);
+        return new Vector4(v3, 1F);
     }
 
     /// <inheritdoc/>
@@ -109,7 +109,7 @@ public static CieLch FromScaledVector4(Vector4 source)
         Vector3 v3 = source.AsVector3();
         v3 *= new Vector3(100, 400, 360);
         v3 -= new Vector3(0, 200, 0);
-        return new(v3, true);
+        return new CieLch(v3, true);
     }
 
     /// <inheritdoc/>
@@ -155,7 +155,7 @@ public static CieLch FromProfileConnectingSpace(ColorConversionOptions options,
             hDegrees += 360;
         }
 
-        return new(l, c, hDegrees);
+        return new CieLch(l, c, hDegrees);
     }
 
     /// <inheritdoc/>
@@ -181,7 +181,7 @@ public CieLab ToProfileConnectingSpace(ColorConversionOptions options)
         float a = c * MathF.Cos(hRadians);
         float b = c * MathF.Sin(hRadians);
 
-        return new(l, a, b);
+        return new CieLab(l, a, b);
     }
 
     /// <inheritdoc/>

src/ImageSharp/ColorProfiles/CieLch.cs

@@ -25,7 +25,7 @@ namespace SixLabors.ImageSharp.ColorProfiles;
     /// <param name="h">The hue in degrees.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public CieLchuv(float l, float c, float h)
-       : this(new(l, c, h))
+       : this(new Vector3(l, c, h))
     {
     }
 
@@ -97,7 +97,7 @@ public Vector4 ToScaledVector4()
         v3 += this.AsVector3Unsafe();
         v3 += new Vector3(0, 200, 0);
         v3 /= new Vector3(100, 400, 360);
-        return new(v3, 1F);
+        return new Vector4(v3, 1F);
     }
 
     /// <inheritdoc/>
@@ -106,7 +106,7 @@ public static CieLchuv FromScaledVector4(Vector4 source)
         Vector3 v3 = source.AsVector3();
         v3 *= new Vector3(100, 400, 360);
         v3 -= new Vector3(0, 200, 0);
-        return new(v3, true);
+        return new CieLchuv(v3, true);
     }
 
     /// <inheritdoc/>
@@ -154,7 +154,7 @@ public static CieLchuv FromProfileConnectingSpace(ColorConversionOptions options
             hDegrees += 360;
         }
 
-        return new(l, c, hDegrees);
+        return new CieLchuv(l, c, hDegrees);
     }
 
     /// <inheritdoc/>

src/ImageSharp/ColorProfiles/CieLchuv.cs

@@ -134,7 +134,7 @@ public static CieLuv FromProfileConnectingSpace(ColorConversionOptions options,
             v = 0;
         }
 
-        return new((float)l, (float)u, (float)v);
+        return new CieLuv((float)l, (float)u, (float)v);
     }
 
     /// <inheritdoc/>
@@ -188,7 +188,7 @@ public CieXyz ToProfileConnectingSpace(ColorConversionOptions options)
             z = 0;
         }
 
-        return new((float)x, (float)y, (float)z);
+        return new CieXyz((float)x, (float)y, (float)z);
     }
 
     /// <inheritdoc/>