Merge pull request #2951 from stefannikolei/sn/ref/explicit_types

Enforce Explicit Types and Target Type new

Author: JimBobSquarePants

src/ImageSharp/Advanced/ParallelExecutionSettings.cs

@@ -79,7 +79,7 @@ public ParallelExecutionSettings MultiplyMinimumPixelsPerTask(int multiplier)
     {
         Guard.MustBeGreaterThan(multiplier, 0, nameof(multiplier));
 
-        return new ParallelExecutionSettings(
+        return new(
             this.MaxDegreeOfParallelism,
             this.MinimumPixelsProcessedPerTask * multiplier,
             this.MemoryAllocator);
@@ -92,6 +92,6 @@ public ParallelExecutionSettings MultiplyMinimumPixelsPerTask(int multiplier)
     /// <returns>The <see cref="ParallelExecutionSettings"/>.</returns>
     public static ParallelExecutionSettings FromConfiguration(Configuration configuration)
     {
-        return new ParallelExecutionSettings(configuration.MaxDegreeOfParallelism, configuration.MemoryAllocator);
+        return new(configuration.MaxDegreeOfParallelism, configuration.MemoryAllocator);
     }
 }

src/ImageSharp/Advanced/ParallelRowIterator.Wrappers.cs

@@ -139,7 +139,7 @@ public void Invoke(int i)
             }
 
             int yMax = Math.Min(yMin + this.stepY, this.maxY);
-            var rows = new RowInterval(yMin, yMax);
+            RowInterval rows = new RowInterval(yMin, yMax);
 
             // Skip the safety copy when invoking a potentially impure method on a readonly field
             Unsafe.AsRef(in this.operation).Invoke(in rows);
@@ -185,7 +185,7 @@ public void Invoke(int i)
             }
 
             int yMax = Math.Min(yMin + this.stepY, this.maxY);
-            var rows = new RowInterval(yMin, yMax);
+            RowInterval rows = new RowInterval(yMin, yMax);
 
             using IMemoryOwner<TBuffer> buffer = this.allocator.Allocate<TBuffer>(this.bufferLength);
 

src/ImageSharp/Advanced/ParallelRowIterator.cs

@@ -26,7 +26,7 @@ public static partial class ParallelRowIterator
     public static void IterateRows<T>(Configuration configuration, Rectangle rectangle, in T operation)
         where T : struct, IRowOperation
     {
-        var parallelSettings = ParallelExecutionSettings.FromConfiguration(configuration);
+        ParallelExecutionSettings parallelSettings = ParallelExecutionSettings.FromConfiguration(configuration);
         IterateRows(rectangle, in parallelSettings, in operation);
     }
 
@@ -65,8 +65,8 @@ public static void IterateRows<T>(
         }
 
         int verticalStep = DivideCeil(rectangle.Height, numOfSteps);
-        var parallelOptions = new ParallelOptions { MaxDegreeOfParallelism = numOfSteps };
-        var wrappingOperation = new RowOperationWrapper<T>(top, bottom, verticalStep, in operation);
+        ParallelOptions parallelOptions = new() { MaxDegreeOfParallelism = numOfSteps };
+        RowOperationWrapper<T> wrappingOperation = new(top, bottom, verticalStep, in operation);
 
         Parallel.For(
             0,
@@ -88,7 +88,7 @@ public static void IterateRows<T, TBuffer>(Configuration configuration, Rectangl
         where T : struct, IRowOperation<TBuffer>
         where TBuffer : unmanaged
     {
-        var parallelSettings = ParallelExecutionSettings.FromConfiguration(configuration);
+        ParallelExecutionSettings parallelSettings = ParallelExecutionSettings.FromConfiguration(configuration);
         IterateRows<T, TBuffer>(rectangle, in parallelSettings, in operation);
     }
 
@@ -135,8 +135,8 @@ public static void IterateRows<T, TBuffer>(
         }
 
         int verticalStep = DivideCeil(height, numOfSteps);
-        var parallelOptions = new ParallelOptions { MaxDegreeOfParallelism = numOfSteps };
-        var wrappingOperation = new RowOperationWrapper<T, TBuffer>(top, bottom, verticalStep, bufferLength, allocator, in operation);
+        ParallelOptions parallelOptions = new() { MaxDegreeOfParallelism = numOfSteps };
+        RowOperationWrapper<T, TBuffer> wrappingOperation = new(top, bottom, verticalStep, bufferLength, allocator, in operation);
 
         Parallel.For(
             0,
@@ -156,7 +156,7 @@ public static void IterateRows<T, TBuffer>(
     public static void IterateRowIntervals<T>(Configuration configuration, Rectangle rectangle, in T operation)
         where T : struct, IRowIntervalOperation
     {
-        var parallelSettings = ParallelExecutionSettings.FromConfiguration(configuration);
+        ParallelExecutionSettings parallelSettings = ParallelExecutionSettings.FromConfiguration(configuration);
         IterateRowIntervals(rectangle, in parallelSettings, in operation);
     }
 
@@ -186,14 +186,14 @@ public static void IterateRowIntervals<T>(
         // Avoid TPL overhead in this trivial case:
         if (numOfSteps == 1)
         {
-            var rows = new RowInterval(top, bottom);
+            RowInterval rows = new(top, bottom);
             Unsafe.AsRef(in operation).Invoke(in rows);
             return;
         }
 
         int verticalStep = DivideCeil(rectangle.Height, numOfSteps);
-        var parallelOptions = new ParallelOptions { MaxDegreeOfParallelism = numOfSteps };
-        var wrappingOperation = new RowIntervalOperationWrapper<T>(top, bottom, verticalStep, in operation);
+        ParallelOptions parallelOptions = new() { MaxDegreeOfParallelism = numOfSteps };
+        RowIntervalOperationWrapper<T> wrappingOperation = new(top, bottom, verticalStep, in operation);
 
         Parallel.For(
             0,
@@ -215,7 +215,7 @@ public static void IterateRowIntervals<T, TBuffer>(Configuration configuration,
         where T : struct, IRowIntervalOperation<TBuffer>
         where TBuffer : unmanaged
     {
-        var parallelSettings = ParallelExecutionSettings.FromConfiguration(configuration);
+        ParallelExecutionSettings parallelSettings = ParallelExecutionSettings.FromConfiguration(configuration);
         IterateRowIntervals<T, TBuffer>(rectangle, in parallelSettings, in operation);
     }
 
@@ -250,7 +250,7 @@ public static void IterateRowIntervals<T, TBuffer>(
         // Avoid TPL overhead in this trivial case:
         if (numOfSteps == 1)
         {
-            var rows = new RowInterval(top, bottom);
+            RowInterval rows = new(top, bottom);
             using IMemoryOwner<TBuffer> buffer = allocator.Allocate<TBuffer>(bufferLength);
 
             Unsafe.AsRef(in operation).Invoke(in rows, buffer.Memory.Span);
@@ -259,8 +259,8 @@ public static void IterateRowIntervals<T, TBuffer>(
         }
 
         int verticalStep = DivideCeil(height, numOfSteps);
-        var parallelOptions = new ParallelOptions { MaxDegreeOfParallelism = numOfSteps };
-        var wrappingOperation = new RowIntervalOperationWrapper<T, TBuffer>(top, bottom, verticalStep, bufferLength, allocator, in operation);
+        ParallelOptions parallelOptions = new() { MaxDegreeOfParallelism = numOfSteps };
+        RowIntervalOperationWrapper<T, TBuffer> wrappingOperation = new(top, bottom, verticalStep, bufferLength, allocator, in operation);
 
         Parallel.For(
             0,

src/ImageSharp/Color/Color.WebSafePalette.cs

@@ -8,7 +8,7 @@ namespace SixLabors.ImageSharp;
 /// </content>
 public partial struct Color
 {
-    private static readonly Lazy<Color[]> WebSafePaletteLazy = new Lazy<Color[]>(CreateWebSafePalette, true);
+    private static readonly Lazy<Color[]> WebSafePaletteLazy = new(CreateWebSafePalette, true);
 
     /// <summary>
     /// Gets a collection of named, web safe colors as defined in the CSS Color Module Level 4.

src/ImageSharp/ColorProfiles/CieLab.cs

@@ -88,7 +88,7 @@ public Vector4 ToScaledVector4()
         v3 += this.AsVector3Unsafe();
         v3 += new Vector3(0, 128F, 128F);
         v3 /= new Vector3(100F, 255F, 255F);
-        return new Vector4(v3, 1F);
+        return new(v3, 1F);
     }
 
     /// <inheritdoc/>
@@ -97,7 +97,7 @@ public static CieLab FromScaledVector4(Vector4 source)
         Vector3 v3 = source.AsVector3();
         v3 *= new Vector3(100F, 255, 255);
         v3 -= new Vector3(0, 128F, 128F);
-        return new CieLab(v3);
+        return new(v3);
     }
 
     /// <inheritdoc/>
@@ -145,7 +145,7 @@ public static CieLab FromProfileConnectingSpace(ColorConversionOptions options,
         float a = 500F * (fx - fy);
         float b = 200F * (fy - fz);
 
-        return new CieLab(l, a, b);
+        return new(l, a, b);
     }
 
     /// <inheritdoc/>

src/ImageSharp/ColorProfiles/CieLch.cs

@@ -25,7 +25,7 @@ namespace SixLabors.ImageSharp.ColorProfiles;
     /// <param name="h">The hue in degrees.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public CieLch(float l, float c, float h)
-        : this(new Vector3(l, c, h))
+        : this(new(l, c, h))
     {
     }
 
@@ -100,7 +100,7 @@ public Vector4 ToScaledVector4()
         v3 += this.AsVector3Unsafe();
         v3 += new Vector3(0, 200, 0);
         v3 /= new Vector3(100, 400, 360);
-        return new Vector4(v3, 1F);
+        return new(v3, 1F);
     }
 
     /// <inheritdoc/>
@@ -109,7 +109,7 @@ public static CieLch FromScaledVector4(Vector4 source)
         Vector3 v3 = source.AsVector3();
         v3 *= new Vector3(100, 400, 360);
         v3 -= new Vector3(0, 200, 0);
-        return new CieLch(v3, true);
+        return new(v3, true);
     }
 
     /// <inheritdoc/>
@@ -155,7 +155,7 @@ public static CieLch FromProfileConnectingSpace(ColorConversionOptions options,
             hDegrees += 360;
         }
 
-        return new CieLch(l, c, hDegrees);
+        return new(l, c, hDegrees);
     }
 
     /// <inheritdoc/>
@@ -181,7 +181,7 @@ public CieLab ToProfileConnectingSpace(ColorConversionOptions options)
         float a = c * MathF.Cos(hRadians);
         float b = c * MathF.Sin(hRadians);
 
-        return new CieLab(l, a, b);
+        return new(l, a, b);
     }
 
     /// <inheritdoc/>

src/ImageSharp/ColorProfiles/CieLchuv.cs

@@ -25,7 +25,7 @@ namespace SixLabors.ImageSharp.ColorProfiles;
     /// <param name="h">The hue in degrees.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public CieLchuv(float l, float c, float h)
-       : this(new Vector3(l, c, h))
+       : this(new(l, c, h))
     {
     }
 
@@ -97,7 +97,7 @@ public Vector4 ToScaledVector4()
         v3 += this.AsVector3Unsafe();
         v3 += new Vector3(0, 200, 0);
         v3 /= new Vector3(100, 400, 360);
-        return new Vector4(v3, 1F);
+        return new(v3, 1F);
     }
 
     /// <inheritdoc/>
@@ -106,7 +106,7 @@ public static CieLchuv FromScaledVector4(Vector4 source)
         Vector3 v3 = source.AsVector3();
         v3 *= new Vector3(100, 400, 360);
         v3 -= new Vector3(0, 200, 0);
-        return new CieLchuv(v3, true);
+        return new(v3, true);
     }
 
     /// <inheritdoc/>
@@ -154,7 +154,7 @@ public static CieLchuv FromProfileConnectingSpace(ColorConversionOptions options
             hDegrees += 360;
         }
 
-        return new CieLchuv(l, c, hDegrees);
+        return new(l, c, hDegrees);
     }
 
     /// <inheritdoc/>

src/ImageSharp/ColorProfiles/CieLuv.cs

@@ -134,7 +134,7 @@ public static CieLuv FromProfileConnectingSpace(ColorConversionOptions options,
             v = 0;
         }
 
-        return new CieLuv((float)l, (float)u, (float)v);
+        return new((float)l, (float)u, (float)v);
     }
 
     /// <inheritdoc/>
@@ -188,7 +188,7 @@ public CieXyz ToProfileConnectingSpace(ColorConversionOptions options)
             z = 0;
         }
 
-        return new CieXyz((float)x, (float)y, (float)z);
+        return new((float)x, (float)y, (float)z);
     }
 
     /// <inheritdoc/>

src/ImageSharp/ColorProfiles/CieXyy.cs

@@ -122,10 +122,10 @@ public static CieXyy FromProfileConnectingSpace(ColorConversionOptions options,
 
         if (float.IsNaN(x) || float.IsNaN(y))
         {
-            return new CieXyy(0, 0, source.Y);
+            return new(0, 0, source.Y);
         }
 
-        return new CieXyy(x, y, source.Y);
+        return new(x, y, source.Y);
     }
 
     /// <inheritdoc/>
@@ -144,14 +144,14 @@ public CieXyz ToProfileConnectingSpace(ColorConversionOptions options)
     {
         if (MathF.Abs(this.Y) < Constants.Epsilon)
         {
-            return new CieXyz(0, 0, this.Yl);
+            return new(0, 0, this.Yl);
         }
 
         float x = (this.X * this.Yl) / this.Y;
         float y = this.Yl;
         float z = ((1 - this.X - this.Y) * y) / this.Y;
 
-        return new CieXyz(x, y, z);
+        return new(x, y, z);
     }
 
     /// <inheritdoc/>

src/ImageSharp/ColorProfiles/CieXyz.cs

@@ -88,7 +88,7 @@ internal Vector4 ToVector4()
     {
         Vector3 v3 = default;
         v3 += this.AsVector3Unsafe();
-        return new Vector4(v3, 1F);
+        return new(v3, 1F);
     }
 
     /// <inheritdoc/>
@@ -97,21 +97,21 @@ public Vector4 ToScaledVector4()
         Vector3 v3 = default;
         v3 += this.AsVector3Unsafe();
         v3 *= 32768F / 65535;
-        return new Vector4(v3, 1F);
+        return new(v3, 1F);
     }
 
     internal static CieXyz FromVector4(Vector4 source)
     {
         Vector3 v3 = source.AsVector3();
-        return new CieXyz(v3);
+        return new(v3);
     }
 
     /// <inheritdoc/>
     public static CieXyz FromScaledVector4(Vector4 source)
     {
         Vector3 v3 = source.AsVector3();
         v3 *= 65535 / 32768F;
-        return new CieXyz(v3);
+        return new(v3);
     }
 
     /// <inheritdoc/>