fix: (betterinventory) add move-while-open and make the slot highlight visible

The module only shipped the clicked-slot highlight, and its Fill mode
drew under the item so it was hidden. Add a MoveWhileOpen option that
keeps movement keys active while a container screen is open (yielding to
the dedicated InvMove module to avoid double-driving keybinds), and draw
the highlight at drawSlot RETURN with a translucent Fill so it renders
over the item.

Author: opZywl

src/main/java/net/ccbluex/liquidbounce/features/module/modules/other/BetterInventory.kt

@@ -9,13 +9,19 @@ import net.ccbluex.liquidbounce.event.UpdateEvent
 import net.ccbluex.liquidbounce.event.handler
 import net.ccbluex.liquidbounce.features.module.Category
 import net.ccbluex.liquidbounce.features.module.Module
+import net.ccbluex.liquidbounce.features.module.modules.movement.InvMove
 import net.ccbluex.liquidbounce.injection.forge.mixins.gui.MixinGuiContainerAccessor
 import net.minecraft.client.gui.inventory.GuiContainer
+import net.minecraft.client.settings.GameSettings
+import net.minecraft.client.settings.KeyBinding
 import org.lwjgl.input.Mouse
 import java.awt.Color
 
 object BetterInventory : Module("BetterInventory", Category.OTHER, Category.SubCategory.MISCELLANEOUS, gameDetecting = false) {
 
+    private val moveWhileOpen by boolean("MoveWhileOpen", true)
+        .describe("Keep walking, sprinting and jumping while an inventory or chest screen is open.")
+
     val highlightClicked by boolean("HighlightClicked", true)
         .describe("Highlight the last slot you clicked.")
     val highlightMode by choices("HighlightMode", arrayOf("Border", "Fill"), "Border") { highlightClicked }
@@ -30,15 +36,28 @@ object BetterInventory : Module("BetterInventory", Category.OTHER, Category.SubC
 
     private var leftHeld = false
     private var rightHeld = false
+    private var drivingMovement = false
+
+    private val movementBindings = arrayOf(
+        mc.gameSettings.keyBindForward,
+        mc.gameSettings.keyBindBack,
+        mc.gameSettings.keyBindLeft,
+        mc.gameSettings.keyBindRight,
+        mc.gameSettings.keyBindJump,
+        mc.gameSettings.keyBindSprint
+    )
 
     val onUpdate = handler<UpdateEvent> {
         val screen = mc.currentScreen as? GuiContainer ?: run {
             clickedSlot = -1
             leftHeld = false
             rightHeld = false
+            releaseMovement()
             return@handler
         }
 
+        driveMovement()
+
         val leftDown = Mouse.isButtonDown(0)
         val rightDown = Mouse.isButtonDown(1)
 
@@ -52,4 +71,27 @@ object BetterInventory : Module("BetterInventory", Category.OTHER, Category.SubC
         leftHeld = leftDown
         rightHeld = rightDown
     }
+
+    /** Presses the movement bindings while a container is open, yielding to the dedicated InvMove module. */
+    private fun driveMovement() {
+        if (!moveWhileOpen || InvMove.handleEvents()) {
+            releaseMovement()
+            return
+        }
+        drivingMovement = true
+        for (binding in movementBindings) binding.pressed = isPhysicallyDown(binding)
+    }
+
+    private fun releaseMovement() {
+        if (!drivingMovement) return
+        drivingMovement = false
+        for (binding in movementBindings) binding.pressed = isPhysicallyDown(binding)
+    }
+
+    private fun isPhysicallyDown(binding: KeyBinding): Boolean =
+        if (binding.keyCode < 0) Mouse.isButtonDown(binding.keyCode + 100) else GameSettings.isKeyDown(binding)
+
+    override fun onDisable() {
+        releaseMovement()
+    }
 }

src/main/java/net/ccbluex/liquidbounce/injection/forge/mixins/gui/MixinGuiContainerHighlight.java

@@ -22,7 +22,7 @@
 @SideOnly(Side.CLIENT)
 public abstract class MixinGuiContainerHighlight extends MixinGuiScreen {
 
-    @Inject(method = "drawSlot", at = @At("HEAD"))
+    @Inject(method = "drawSlot", at = @At("RETURN"))
     private void drawSlot(Slot slot, CallbackInfo ci) {
         final BetterInventory betterInventory = BetterInventory.INSTANCE;
 
@@ -41,9 +41,12 @@ private void drawSlot(Slot slot, CallbackInfo ci) {
         glPushMatrix();
         glPushAttrib(GL_ENABLE_BIT);
         glDisable(GL_LIGHTING);
+        glDisable(GL_DEPTH_TEST);
 
         if ("Fill".equals(betterInventory.getHighlightMode())) {
-            RenderUtils.INSTANCE.drawRect(x, y, x + 16, y + 16, color);
+            // Render over the drawn item with a translucent tint so the item stays visible.
+            int fill = (color & 0x00FFFFFF) | 0x66000000;
+            RenderUtils.INSTANCE.drawRect(x, y, x + 16, y + 16, fill);
         } else {
             RenderUtils.INSTANCE.drawBorder(x, y, x + 16, y + 16, betterInventory.getBorderWidth(), color);
         }