Skip to content

fix(ci): apply prettier --write to 3 drifted files#1806

Merged
Skords-01 merged 2 commits into
mainfrom
devin/1777938775-fix-prettier-formatting-on-main-v2
May 4, 2026
Merged

fix(ci): apply prettier --write to 3 drifted files#1806
Skords-01 merged 2 commits into
mainfrom
devin/1777938775-fix-prettier-formatting-on-main-v2

Conversation

@Skords-01
Copy link
Copy Markdown
Owner

@Skords-01 Skords-01 commented May 4, 2026

Summary

Pure formatting fix. No semantic changes. Files were drifted on main (failing pnpm format:check, part of the required check CI job). This blocks merges of multiple Dependabot PRs (#1650, #1559, #1587, #1557, #1558).

Files touched (formatting-only):

  • docs/diagnostics/2026-05-03-web-deep-dive/00-overview.md
  • docs/diagnostics/README.md
  • scripts/check-localstorage-allowlist.mjs

Replaces #1802 (which was based on stale main missing the #1778 i18n governance-sync fix).

Governing Skill

  • Primary skill: sergeant-bugfix-and-regression

Playbook

  • Primary playbook: n/a (pure prettier auto-fix)
  • Why this playbook: trivial mechanical fix, no design judgment.
  • If no playbook matched, why: prettier-drift cleanup is too small for a playbook.

Verification

# Before the fix:
node_modules/.bin/prettier --check .
# 3 warnings, exit 1

# After the fix:
node_modules/.bin/prettier --check .
# All matched files use Prettier code style!  exit 0

# Also confirmed governance-sync clean:
node scripts/check-governance-sync.mjs
# Errors: 0, Warnings: 136 (warnings are aspirational refs, allowed)

Additional checks:

  • Local smoke: prettier check exits 0.
  • Local smoke: governance-sync check exits 0 (no blocking errors).
  • git diff --stat shows only whitespace/format changes (no semantic edits).

Docs and Governance

  • I updated docs that changed with the behavior, contract, workflow, or rollout. (n/a — no behavior change; all 3 files are docs but the changes are pure prettier whitespace)
  • I checked whether AGENTS.md needed an update. (no)
  • I checked whether a playbook or skill needed an update. (no)
  • I checked whether governance docs or review docs needed an update. (no)

Updated docs:

  • docs/diagnostics/2026-05-03-web-deep-dive/00-overview.md — pure prettier reflow (line wrapping)
  • docs/diagnostics/README.md — pure prettier reflow

Risk and Rollout

  • User-visible risk: none.
  • Rollout / deploy order: merge → required check CI on Dependabot bumps unblocks → those merge.
  • Backout plan: revert this commit.

Hard Rule #15

  • I read AGENTS.md before coding.
  • Internal docs I touched are in Ukrainian. (yes — docs were already in Ukrainian; only formatting changed)
  • I did not use --no-verify.

Reviewer Notes

The diff is exclusively prettier whitespace/wrap. Confirm by running git diff -w (whitespace-only).


Summary by cubic

Fix formatting drift so pnpm format:check passes in the required check CI job, unblocking pending Dependabot PRs. Applied prettier --write to docs/diagnostics/2026-05-03-web-deep-dive/00-overview.md, docs/diagnostics/README.md, and scripts/check-localstorage-allowlist.mjs after syncing with main; no behavior changes.

Written for commit 8b36358. Summary will update on new commits.

Pure formatting fix. No semantic changes. Files were drifted on main
(failing 'pnpm format:check' which is part of the required 'check' CI
job), blocking merges of multiple Dependabot PRs (#1650/#1559/#1587/
#1557/#1558).

Files:
- docs/diagnostics/2026-05-03-web-deep-dive/00-overview.md
- docs/diagnostics/README.md
- scripts/check-localstorage-allowlist.mjs

Local verification:
  node_modules/.bin/prettier --check .  → exit 0
  node scripts/check-governance-sync.mjs → exit 0 (Errors: 0)

Co-Authored-By: Бу Ка <dmytro.s.stakhov@gmail.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sergeant Ready Ready Preview, Comment May 5, 2026 0:02am

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Warning

Rate limit exceeded

@Skords-01 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 53 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d74a536e-e0d3-4462-93aa-a3dde851bb4f

📥 Commits

Reviewing files that changed from the base of the PR and between 1cf899b and 8b36358.

📒 Files selected for processing (3)
  • docs/diagnostics/2026-05-03-web-deep-dive/00-overview.md
  • docs/diagnostics/README.md
  • scripts/check-localstorage-allowlist.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1777938775-fix-prettier-formatting-on-main-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/S label May 4, 2026
@Skords-01 Skords-01 merged commit 98f8e19 into main May 4, 2026
12 of 17 checks passed
@Skords-01 Skords-01 deleted the devin/1777938775-fix-prettier-formatting-on-main-v2 branch May 4, 2026 23:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

⏱️ CI Pipeline Duration Report

Based on the last 50 successful runs on the default branch.

Overall Pipeline

Metric Value
p50 6m 26s
p95 7m 55s
p99 9m 3s
Current run 19m 11s
vs p95 +142.3%

Trend (last 20 runs): ▃▃▁▂▃▃▃▂▃▃▂▂▄▃▃▆▅▄█▆

Per-Job Breakdown

Job p50 p95 p99 Current vs p95
Accessibility (axe-core) 2m 5s 2m 21s 2m 23s 0s -100.7%
Commit messages (commitlint) 0s 0s 0s 47s N/A
Critical-flow E2E (Playwright) 1m 36s 1m 44s 1m 44s 5m 59s +245.2%
Migration lint (AGENTS rule 0s 0s 0s 7s N/A
Pipeline duration (p95 trend) 26s 27s 27s
Secret scan (gitleaks) 8s 11s 11s 9s -18.2%
Smoke E2E (Playwright) 1m 26s 1m 40s 1m 40s
Test coverage (vitest) 2m 4s 2m 33s 2m 33s 1m 21s -47.1%
Workflow lint (actionlint) 7s 7s 7s 6s -14.3%
check 4m 12s 4m 54s 5m 6s 2m 47s -43.2%
tsconfig strict guard (PR-1.A) 5s 14s 14s 6s -57.1%

⚠️ Warning: Current run (19m 11s) exceeds p95 + 20% threshold (9m 30s). Consider reviewing slow jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant