Add missing PDC syntaxes#8528
Merged
sovdeeth merged 4 commits intoSkriptLang:dev/featurefrom Apr 12, 2026
Merged
Conversation
sovdeeth
added
bug
sovdeeth
requested review from
TheMug06 and
cheeezburga
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
sovdeeth
commented
Apr 7, 2026
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Absolutionism
approved these changes
Apr 7, 2026
APickledWalrus
requested changes
Apr 9, 2026
APickledWalrus
approved these changes
Apr 11, 2026
| registry.register(SyntaxRegistry.EXPRESSION, | ||
| SyntaxInfo.Expression.builder(ExprAllPersistentDataKeys.class, String.class) | ||
| .addPatterns( | ||
| "[all [[of] the]] [persistent] data [tag] keys of %objects%", |
Member
There was a problem hiding this comment.
Suggested change
| "[all [[of] the]] [persistent] data [tag] keys of %objects%", | |
| "[all [[of] the]|the] [persistent] data [tag] keys of %objects%", |
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.15 Releases
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.15 Releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The original PDC PR forgot the necessary
has tagcondition syntax and theall tagsexpression.Solution
Adds a condition to check if a holder has a specific tag, and an expression to get the keys available on a holder.
Reworked the edit/get container utility methods and put them in a utils class.
Testing Completed
Added automated tests via Claude Code.
Supporting Information
Completes: none
Related: none
AI assistance: Claude generated the test scripts.