Events Migration (Entity Events)#8748
Open
AnOwlBe wants to merge 31 commits into
Open
Conversation
…ew over all files)
AnOwlBe
requested review from
Pesekjak and
cheeezburga
and removed request for
a team
skriptlang-automation
Bot
added
needs reviews
🔍 Triage ChecklistType
Project
|
Absolutionism
requested changes
Jul 3, 2026
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Absolutionism
requested changes
Jul 4, 2026
# Conflicts: # src/main/java/org/skriptlang/skript/bukkit/entity/elements/events/EvtEntityBlockChange.java
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Absolutionism
requested changes
Jul 5, 2026
Absolutionism
left a comment
Absolutionism
left a comment
Contributor
There was a problem hiding this comment.
A lot of Space Invaders too
| @SuppressWarnings("unchecked") | ||
| public boolean init(Literal<?>[] args, int matchedPattern, ParseResult parseResult) { | ||
| if (args[0] != null) { | ||
| entityData = (Literal<EntityData<?>>) args[0]; |
Contributor
There was a problem hiding this comment.
Perhaps we should check to see what entity types are provided, and if one or more is not of the types that can trigger this event, to error and inform
Author
There was a problem hiding this comment.
I guess but also could be limiting in future and as is its not really confusing a user won't have the event and expect a pig to break down a door
…nts/EvtEntityDamage.java Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Absolutionism
requested changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This is part 2 of probably 6-8 more prs needed to migrate all of simpleevents & njol/skript/events into the skriptlang folder in their related module while (hopefully) preventing any breaking changes.
Solution
This PR is targetted at entity events in SimpleEvents (Events in Bukkit/Paper that start with Entity or entity specific events)
Also migrates all entity events in njol/skript/events (probably)
progress:
Testing Completed
Manual testing completed for every event along with junit & quicktest passed
If anyone wants to test themselves for bugs or breaking changes: entityevents.txt
Supporting Information
Note that the stuff in BukkitModule will exist until #8741 replaces it when 2.16 is officially out allowing it to be merged into dev/feature
Completes: none
Related: #8716
AI assistance: some here and there but about 90% done by me