Skip to content

Commit 85d940e

Browse files
Add type references for function card parameters
1 parent 38a8055 commit 85d940e

2 files changed

Lines changed: 10 additions & 7 deletions

File tree

src/components/syntaxes/SyntaxBadge.astro

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,13 @@ interface Props {
1010
cardRefText?: string,
1111
}[],
1212
description?: string,
13+
useOrganizedDisplay?: boolean,
1314
}
1415
15-
const { badgeProps, entries, description }: Props = Astro.props;
16+
const { badgeProps, entries, description, useOrganizedDisplay = true }: Props = Astro.props;
1617
---
1718

18-
<span class="prefix-badge" title={description}>
19+
<span class=`prefix-badge ${useOrganizedDisplay ? 'entry-grid-display' : ''}` title={description}>
1920
<Badge {...badgeProps} class="cb"/>
2021
{entries.map(({ text, cardRef, cardRefText }, index) =>
2122
<>
@@ -45,10 +46,10 @@ const { badgeProps, entries, description }: Props = Astro.props;
4546
padding: 0;
4647
margin: 0;
4748
}
48-
.prefix-badge span, p:not(:last-child) {
49+
.prefix-badge span, .entry-grid-display p:not(:last-child) {
4950
margin-right: 0.25rem;
5051
}
51-
.prefix-badge:has(.card-ref) {
52+
.entry-grid-display:has(.card-ref) {
5253
display: grid;
5354
grid-template-columns: fit-content(100%) auto;
5455
grid-gap: 0 0.5rem;

src/components/syntaxes/cards/FunctionCard.astro

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,21 +27,23 @@ const { defaultProps, func }: Props = Astro.props;
2727
<div class="code-card show-all">
2828
<span class="title">Function Parameters</span>
2929
{Object.values(func.parameters).map(parameter => {
30-
let description = changeSingular(parameter.type.name, parameter.plural);
30+
let name = changeSingular(parameter.type.name, parameter.plural);
31+
let description = "";
3132
if (parameter.modifiers) {
3233
if (parameter.modifiers.ranged) {
3334
description += ` (between ${parameter.modifiers.ranged.min} and ${parameter.modifiers.ranged.max})`;
3435
}
3536
if (parameter.modifiers.optional) {
36-
if (!description.endsWith(" ")) {
37+
if (description.length !== 0) {
3738
description += ", ";
3839
}
3940
description += "optional"
4041
}
4142
}
4243
return (<SyntaxBadge
4344
badgeProps={{text: parameter.name, size: 'medium'}}
44-
entries={[{text: description}]}
45+
entries={[{text: name, cardRef: parameter.type.id, cardRefText: description}]}
46+
useOrganizedDisplay={false}
4547
/>);
4648
})}
4749
</div>

0 commit comments

Comments
 (0)