-
-
Notifications
You must be signed in to change notification settings - Fork 29
Rewrite Custom Syntax #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
UnderscoreTud
wants to merge
56
commits into
2.x
Choose a base branch
from
feature/custom-syntax-rewrite
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
45d203d
Update build.gradle and switch to jetbrains annotations
UnderscoreTud a59dec3
Remove unused import and extra trailing line
UnderscoreTud 106bab3
Rewrite custom syntaxes
UnderscoreTud 25a57af
Make ExprChangeValue return the possible return types
UnderscoreTud 02a4ad8
Register ChangerData
UnderscoreTud 78160ae
Check for array types in accepted classes and add a plurality check
UnderscoreTud 8653bea
Improve return type and plurality handling for ExprExpression
UnderscoreTud b76caea
Merge branch '2.x' into feature/custom-syntax-rewrite
UnderscoreTud 5a3b907
Resolve conflicts
UnderscoreTud 86aaefb
Finish up the custom event implementation
UnderscoreTud aae2dc4
Remove debug statements
UnderscoreTud 00d4fb5
Add an expression to reference 'self' for custom syntax
UnderscoreTud f37f449
Optimize imports
UnderscoreTud 78ebcc0
Store ExpressionsData and ChangerData directly on the structure rathe…
UnderscoreTud 841e0b1
Fix parse error in custom condition.sk
UnderscoreTud 93d233a
Fix index handling in ExprExpression
UnderscoreTud 11bb490
Fix plurality handling for custom property expressions
UnderscoreTud a6e30f1
Fix 'parse' and 'check' sections load order for custom events
UnderscoreTud fd36d30
Infer custom expression plurality from return type
UnderscoreTud 2889fb9
Implement ReturnHandler for reflect sections
UnderscoreTud 09d14ef
Store the original context of lazy expressions
UnderscoreTud cf2b2af
Allow the 'get' section of property expressions to return multiple va…
UnderscoreTud e90d67b
Fix accepted classes for a changer getting flattened from array type
UnderscoreTud 41e3383
Refactor custom syntax classes to use info classes
UnderscoreTud 8f8d7d9
Store origin on custom syntaxes
UnderscoreTud 5865211
Merge branch '2.x' into feature/custom-syntax-rewrite
UnderscoreTud c054722
Migrate to new event value API and move away from dynamically generat…
UnderscoreTud bafacce
Fix ExprCustomEvent init
UnderscoreTud 999184c
Allow CustomEvents to be executed asynchronously
UnderscoreTud e94ddf3
Use builtin OriginApplyingSyntaxRegistry
UnderscoreTud 90bc4d1
Estimate priority
UnderscoreTud d44e88f
Remove deprecated raw expression pattern
UnderscoreTud 7a09d77
Reintroduce custom syntax tracking
UnderscoreTud 992f766
Replace reflection with proper API call for unloading options
UnderscoreTud 998503c
Replace useless TriggerEntryData with Skript's equivalent
UnderscoreTud c8d9fca
Replace getEnglishPlural with non deprecated method
UnderscoreTud bb6b140
Replace ExprEventClasses with proper event value
UnderscoreTud 6595aff
Delete unused priority constants and ExprEventClasses registration
UnderscoreTud 583f282
Cache script variable outside loop
UnderscoreTud dbd1950
Migrate ExprRawExpression to using infoBuilder
UnderscoreTud 4853c6c
Move isSingle before getReturnType
UnderscoreTud b7ec66f
Delete unused syntax registry class
UnderscoreTud e39f093
Cache result of Utils.getSuperType(possibleReturnTypes)
UnderscoreTud 5b70c69
Annotate custom syntax classes with NoDoc
UnderscoreTud ef1b72b
Make `isMarkedContinue` a part of the Continuable interface
UnderscoreTud 17f34a1
Use pattern matching for instanceof in check method of CondEventCance…
UnderscoreTud 24bed03
Fix effect sync handling
UnderscoreTud 6ed522b
Store return type in ExprChangeValue to optimize getReturnType method
UnderscoreTud 0d78476
Add deprecation warning for missing 'parse' in expressions
UnderscoreTud ef687f9
Rename variable
UnderscoreTud 58c4494
Update Skript dependency to 2.15.3
UnderscoreTud 0a84dea
Rename LazyExpression to CachingExpression
UnderscoreTud 400de64
Add clarifying comment for custom event registration
UnderscoreTud a2197ea
Add 'raw expression %objects%' back as a valid pattern
UnderscoreTud 0ce9079
Improve local variable tracking
UnderscoreTud c50f858
Cleanup ExprCustomEvent toString
UnderscoreTud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 0 additions & 37 deletions
37
src/main/java/com/btk5h/skriptmirror/skript/custom/CustomSyntaxEvent.java
This file was deleted.
Oops, something went wrong.
57 changes: 0 additions & 57 deletions
57
src/main/java/com/btk5h/skriptmirror/skript/custom/CustomSyntaxExpression.java
This file was deleted.
Oops, something went wrong.
57 changes: 0 additions & 57 deletions
57
src/main/java/com/btk5h/skriptmirror/skript/custom/EffContinue.java
This file was deleted.
Oops, something went wrong.
47 changes: 0 additions & 47 deletions
47
src/main/java/com/btk5h/skriptmirror/skript/custom/ExprEventClasses.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.