git: Sign revup-created commits when commit.gpgSign is set#264
Merged
Conversation
Collaborator
Author
|
Reviews in this chain: |
Collaborator
Author
jerry-skydio
force-pushed
the
jerry/revup/main/gpg
branch
from
b9f545a to
21e4b07
Compare
anurag-makineni-wayve
approved these changes
Jun 22, 2026
anurag-makineni-wayve
left a comment
anurag-makineni-wayve
left a comment
Contributor
There was a problem hiding this comment.
looks great, thanks @jerry-skydio!
commit-tree (plumbing) ignores commit.gpgSign, so read it from git config and pass -S explicitly. Read in the existing make_git async gather alongside the other config lookups. Co-Authored-By: Anurag Makineni <anurag.makineni@wayve.ai>
jerry-skydio
force-pushed
the
jerry/revup/main/gpg
branch
from
21e4b07 to
de8b12a
Compare
brian-kubisiak-skydio
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit-tree (plumbing) ignores commit.gpgSign, so read it from git
config and pass -S explicitly. Read in the existing make_git async
gather alongside the other config lookups.
Co-Authored-By: Anurag Makineni anurag.makineni@wayve.ai