feat: item stars display#588
Open
TakoTheDev wants to merge 3 commits into
Open
Conversation
Sychic
requested changes
Feb 22, 2026
Member
There was a problem hiding this comment.
In general, I'd like to avoid this kind of hook style class. I think it's fine if you want a kotlin helper to handle parsing the item name but imo business logic should be directly in the mixin.
Comment on lines
+27
to
+34
| when (Config.starDisplayType) { | ||
| 1 -> { | ||
| out.append(current) | ||
|
|
||
| if (masters > 0) { | ||
| out.append(Text.literal(star.toString().repeat(masters)).formatted(Formatting.RED)) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Did it really use to just put the stars on at the end? I remember it would replace the stars. i.e. if it was 8 starts it'd be 3 red and 2 gold.
Contributor
Author
There was a problem hiding this comment.
lmao yea I remembered it wrong, you're right
will fix tomorrow probably
also made some of the logic be in the java class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while it works, I don't think Injecting ItemStack#getName is the most performant idea (may be better to just do it specifically for HandledScreen Tooltip Rendering and InGameHud Item Name Popup)