Fix leaked DIR* handle in generatedEntryIndex()#253
Open
datacarismo wants to merge 1 commit into
Open
Conversation
Wrap opendir() result in std::unique_ptr with closedir deleter to ensure the directory handle is always released, preventing a file descriptor leak on every call. Also add a null check for the case where opendir() fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a file descriptor leak in
Clipboard::generatedEntryIndex()where theDIR*returned byopendir()was never passed toclosedir().Changes
opendir()return value with early returndirptrinstd::unique_ptr<DIR, decltype(&closedir)>for RAII cleanup#include <memory>Impact
This leak occurred on every clipboard operation that called
generatedEntryIndex()(essentially every invocation on Unix-like systems). Over time, repeated use could exhaust available file descriptors.