Fix CS

Author: Slamdunk

.gitattributes

@@ -5,4 +5,5 @@
 .php-cs-fixer.php export-ignore
 Makefile export-ignore
 phpstan.neon export-ignore
+phpstan-baseline.neon export-ignore
 phpunit.xml export-ignore

composer.json

@@ -42,14 +42,14 @@
         "laminas/laminas-i18n": "^2.11.2",
         "laminas/laminas-inputfilter": "^2.12.0",
         "laminas/laminas-log": "^2.13.1",
-        "laminas/laminas-mail": "^2.14.1",
+        "laminas/laminas-mail": "^2.15.0",
         "laminas/laminas-mvc": "^3.2.0",
         "laminas/laminas-paginator": "^2.10.0",
         "laminas/laminas-validator": "^2.15.0",
         "malukenho/mcbumpface": "^1.1.5",
         "phpstan/phpstan-phpunit": "^0.12.22",
         "phpunit/phpunit": "^9.5.9",
-        "slam/php-cs-fixer-extensions": "^v3.0.1",
+        "slam/php-cs-fixer-extensions": "^v3.1.0",
         "slam/php-debug-r": "^v1.7.0"
     },
     "extra": {

phpstan-baseline.neon

@@ -0,0 +1,7 @@
+parameters:
+	ignoreErrors:
+		-
+			message: "#^Parameter \\#2 \\$args of static method PHPStan\\\\Reflection\\\\ParametersAcceptorSelector\\:\\:selectFromArgs\\(\\) expects array\\<PhpParser\\\\Node\\\\Arg\\>, array\\<PhpParser\\\\Node\\\\Arg\\|PhpParser\\\\Node\\\\VariadicPlaceholder\\> given\\.$#"
+			count: 1
+			path: src/Type/Laminas/PluginMethodDynamicReturnTypeExtension/AbstractPluginMethodDynamicReturnTypeExtension.php
+

phpstan.neon

@@ -1,5 +1,6 @@
 includes:
     - vendor/phpstan/phpstan-phpunit/extension.neon
+    - phpstan-baseline.neon
 
 parameters:
     level: max

src/Rules/Laminas/ServiceManagerGetMethodCallRule.php

@@ -10,6 +10,7 @@
 use LaminasPhpStan\ServiceManagerLoader;
 use LaminasPhpStan\Type\Laminas\ObjectServiceManagerType;
 use PhpParser\Node;
+use PhpParser\Node\Arg;
 use PHPStan\Analyser\Scope;
 use PHPStan\Broker\Broker;
 use PHPStan\Rules\Rule;
@@ -49,7 +50,11 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $argType = $scope->getType($node->args[0]->value);
+        $firstArg = $node->args[0];
+        if (! $firstArg instanceof Arg) {
+            return [];
+        }
+        $argType = $scope->getType($firstArg->value);
         if (! $argType instanceof ConstantStringType) {
             return [];
         }
@@ -100,7 +105,7 @@ public function processNode(Node $node, Scope $scope): array
         )];
     }
 
-    protected function isTypeInstanceOfContainer(ObjectType $type): bool
+    private function isTypeInstanceOfContainer(ObjectType $type): bool
     {
         return $type->isInstanceOf(ServiceLocatorInterface::class)->yes()
             || $type->isInstanceOf(InteropContainerInterface::class)->yes()

src/Type/Laminas/PluginMethodDynamicReturnTypeExtension/AbstractPluginMethodDynamicReturnTypeExtension.php

@@ -5,6 +5,7 @@
 namespace LaminasPhpStan\Type\Laminas\PluginMethodDynamicReturnTypeExtension;
 
 use LaminasPhpStan\ServiceManagerLoader;
+use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\MethodReflection;
@@ -35,7 +36,16 @@ final public function getTypeFromMethodCall(
         MethodCall $methodCall,
         Scope $scope
     ): Type {
-        $argType = $scope->getType($methodCall->args[0]->value);
+        $firstArg = $methodCall->args[0];
+        if (! $firstArg instanceof Arg) {
+            throw new \PHPStan\ShouldNotHappenException(\sprintf(
+                'Argument passed to %s::%s should be a string, %s given',
+                $methodReflection->getDeclaringClass()->getName(),
+                $methodReflection->getName(),
+                $firstArg->getType()
+            ));
+        }
+        $argType = $scope->getType($firstArg->value);
         $strings = TypeUtils::getConstantStrings($argType);
         $plugin  = 1 === \count($strings) ? $strings[0]->getValue() : null;
 

src/Type/Laminas/ServiceManagerGetDynamicReturnTypeExtension.php

@@ -7,6 +7,7 @@
 use Laminas\ServiceManager\AbstractPluginManager;
 use Laminas\ServiceManager\ServiceLocatorInterface;
 use LaminasPhpStan\ServiceManagerLoader;
+use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Broker\Broker;
@@ -62,7 +63,16 @@ public function getTypeFromMethodCall(
 
         $serviceManager = $this->serviceManagerLoader->getServiceLocator($calledOnType->getClassName());
 
-        $argType = $scope->getType($methodCall->args[0]->value);
+        $firstArg = $methodCall->args[0];
+        if (! $firstArg instanceof Arg) {
+            throw new \PHPStan\ShouldNotHappenException(\sprintf(
+                'Argument passed to %s::%s should be a string, %s given',
+                $methodReflection->getDeclaringClass()->getName(),
+                $methodReflection->getName(),
+                $firstArg->getType()
+            ));
+        }
+        $argType = $scope->getType($firstArg->value);
         if (! $argType instanceof ConstantStringType) {
             if ($serviceManager instanceof AbstractPluginManager) {
                 $refClass    = new ReflectionClass($serviceManager);

tests/Rules/Laminas/ServiceManagerGetMethodCallRuleTest.php

@@ -21,6 +21,11 @@ final class ServiceManagerGetMethodCallRuleTest extends RuleTestCase
 {
     private ServiceManagerLoader $serviceManagerLoader;
 
+    protected function setUp(): void
+    {
+        $this->serviceManagerLoader = new ServiceManagerLoader(null);
+    }
+
     /**
      * @return string[][]
      */
@@ -33,11 +38,6 @@ public function provideContainerTypes(): array
         ];
     }
 
-    protected function setUp(): void
-    {
-        $this->serviceManagerLoader = new ServiceManagerLoader(null);
-    }
-
     /**
      * @return Rule<\PhpParser\Node\Expr\MethodCall>
      */